Fix mapping char_filter when mapping a hashtag (#7591)#8147
Merged
kartg merged 1 commit intoJun 19, 2023
Conversation
Signed-off-by: Nathan Myles <myles.n.a@gmail.com> Issue: opensearch-project#7308 (cherry picked from commit e049338)
nathanmyles
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
Contributor
Author
|
Backports: #7591 |
kartg
approved these changes
Jun 19, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
This has cropped up in a some other It seems related to an old flaky test (#1957). A fix for this seems to have merged in - #2265 - but the test remains flaky on this branch. I'll refire Gradle check. |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 1.x #8147 +/- ##
============================================
- Coverage 77.62% 77.61% -0.02%
+ Complexity 58808 58783 -25
============================================
Files 4223 4223
Lines 253545 253547 +2
Branches 38714 38714
============================================
- Hits 196818 196786 -32
- Misses 40715 40771 +56
+ Partials 16012 15990 -22
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathan Myles myles.n.a@gmail.com
Issue: #7308 (cherry picked from commit e049338)