Update all guava#8107
Merged
Merged
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
reta
reviewed
Jun 16, 2023
reta
reviewed
Jun 16, 2023
Contributor
|
Thanks a lot @scrawfor99 ! |
Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Contributor
Author
No problem :) |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8107 +/- ##
============================================
+ Coverage 70.92% 71.00% +0.07%
- Complexity 56664 56723 +59
============================================
Files 4722 4722
Lines 267604 267604
Branches 39214 39214
============================================
+ Hits 189803 190017 +214
+ Misses 61826 61585 -241
- Partials 15975 16002 +27
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
approved these changes
Jun 16, 2023
Member
owaiskazi19
left a comment
There was a problem hiding this comment.
Thanks for this @scrawfor99!
kotwanikunal
approved these changes
Jun 16, 2023
Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8107-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a31e159ad9965536e9f0a8ffce0f3d50243705a8
# Push it to GitHub
git push --set-upstream origin backport/backport-8107-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Contributor
|
@scrawfor99 mind please backport manually? thank you |
This was referenced Jun 16, 2023
kartg
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Backport guava Signed-off-by: Stephen Crawford <steecraw@amazon.com> * fix exclusions Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…pensearch-project#8114) * Backport guava Signed-off-by: Stephen Crawford <steecraw@amazon.com> * fix exclusions Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
* Update all guava Signed-off-by: Stephen Crawford <steecraw@amazon.com> * changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * remove ignors Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix ignores Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update plugins/repository-gcs/build.gradle Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> * Update plugins/repository-azure/build.gradle Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Update all guava Signed-off-by: Stephen Crawford <steecraw@amazon.com> * changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * remove ignors Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Fix ignores Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update plugins/repository-gcs/build.gradle Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> * Update plugins/repository-azure/build.gradle Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When trying to resolve the dependencies for the gcs plugin, I noticed that in some places, we used the older Guava version. We can see here that everything before 32.0.1-jre has a vulnerability: https://mvnrepository.com/artifact/com.google.guava/guava.
Updating elsewhere just to be safe.
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.