[Refactor] Serverless common classes to libraries#8065
Merged
nknize merged 3 commits intoopensearch-project:mainfrom Jun 16, 2023
Merged
[Refactor] Serverless common classes to libraries#8065nknize merged 3 commits intoopensearch-project:mainfrom
nknize merged 3 commits intoopensearch-project:mainfrom
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
I think this change should have a changelog entry. |
Contributor
Author
We haven't decided if these refactors will be backported to 2.x yet so changlog isn't being updated yet. That will be done in bulk if/when we decide which version the refactoring will be released. |
andrross
reviewed
Jun 14, 2023
libs/core/src/main/java/org/opensearch/core/common/StopWatch.java
Outdated
Show resolved
Hide resolved
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
0a08916 to
6ecc26a
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8065 +/- ##
============================================
+ Coverage 70.85% 70.97% +0.11%
- Complexity 56553 56672 +119
============================================
Files 4722 4722
Lines 267594 267594
Branches 39212 39212
============================================
+ Hits 189600 189912 +312
+ Misses 61983 61678 -305
+ Partials 16011 16004 -7
|
andrross
reviewed
Jun 15, 2023
6ecc26a to
51ce245
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
51ce245 to
40ebe87
Compare
Contributor
Author
|
Unrelated BWC failures... rebased and pushed update. |
reta
reviewed
Jun 15, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
40ebe87 to
fe0d40f
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Jun 16, 2023
kasundra07
pushed a commit
to harishbhakuni/OpenSearch
that referenced
this pull request
Jun 16, 2023
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
3 tasks
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8065-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8eea7b986453271cd227a7b98ee09e70d5e28634
# Push it to GitHub
git push --set-upstream origin backport/backport-8065-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jul 7, 2023
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added a commit
that referenced
this pull request
Jul 7, 2023
This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…#8065) This commit refactors common classes from the server module common package to the common and core library so they can be used across serverless and cloud native implementations without depending on the server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors common classes that are decoupled from the server implementation from the
:servercommon package to the:libs:opensearch-commonand:libs:opensearch-corelibrary so they can be used across serverless and cloud native implementations without depending on the monolithic:servermodule and all transitive dependencies.dependency of #8035
relates #5910