Revert "SegRep with Remote: Add hook for publishing checkpoint notifi…#7839
Merged
dreamer-89 merged 1 commit intoopensearch-project:2.8from May 31, 2023
Merged
Revert "SegRep with Remote: Add hook for publishing checkpoint notifi…#7839dreamer-89 merged 1 commit intoopensearch-project:2.8from
dreamer-89 merged 1 commit intoopensearch-project:2.8from
Conversation
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <ankikala@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
ankitkala
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja and
tlfeng
as code owners
Member
|
@ankitkala : Why are we reverting this change ? Why only in |
Member
Author
Updated the details in PR description. |
dreamer-89
approved these changes
May 31, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cations after segment upload to remote store (#7394) (#7718)"
This reverts commit 92571b7.
Reverting this commit as a safety measure as we've not yet merged the other half of Segrep Remote store integration. Thus it can lead to unintended side effects if user has enabled SegRep and Remote store experimental flag.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.