[Backport 2.x] Add connectToNodeAsExtension in TransportService#7346
Merged
owaiskazi19 merged 3 commits intoopensearch-project:2.xfrom May 1, 2023
Merged
Conversation
…6866) * Add connectToNodeAsExtension in TransportService Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update java docstrings Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit b752555)
cwperks
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
ryanbogan,
saratvemulapalli,
setiah,
shwetathareja,
tlfeng and
xuezhou25
as code owners
Signed-off-by: Craig Perkins <cwperx@amazon.com>
owaiskazi19
reviewed
May 1, 2023
CHANGELOG.md
Outdated
| - [Remote Store] Integrate remote segment store in peer recovery flow ([#6664](https://github.com/opensearch-project/OpenSearch/pull/6664)) | ||
| - [Segment Replication] Add new cluster setting to set replication strategy by default for all indices in cluster. ([#6791](https://github.com/opensearch-project/OpenSearch/pull/6791)) | ||
| - Enable sort optimization for all NumericTypes ([#6464](https://github.com/opensearch-project/OpenSearch/pull/6464) | ||
| - Remove 'cluster_manager' role attachment when using 'node.master' deprecated setting ([#6331](https://github.com/opensearch-project/OpenSearch/pull/6331)) |
Member
There was a problem hiding this comment.
Why are we adding these changes to CHANGELOG? They have already been released in 2.7.
Just the below change should be enough for this PR.
Member
There was a problem hiding this comment.
Also, I think this was missed during the review of #6866 . Since we are backporting it to 2.x and it will be released in 2.8 we don't need to add the CHANGELOG entry under unreleased 3.x but rather unreleased 2.x. This was the reason of the failed backport workflow. I would suggest to raise another PR on main and add the change under 2.x and remove it from 3.x.
Member
Author
There was a problem hiding this comment.
Updated, I used the merge conflict tool on github when resolving the conflict. I'm not sure how all of the other items got included.
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
approved these changes
May 1, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #7346 +/- ##
============================================
+ Coverage 70.37% 70.38% +0.01%
+ Complexity 59731 59728 -3
============================================
Files 4850 4850
Lines 287193 287212 +19
Branches 41727 41728 +1
============================================
+ Hits 202104 202147 +43
+ Misses 68177 68147 -30
- Partials 16912 16918 +6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6866 to 2.x