[Backport 2.x] Require MediaType in Strings.toString API (#6009)#6414
[Backport 2.x] Require MediaType in Strings.toString API (#6009)#6414nknize merged 2 commits intoopensearch-project:2.xfrom
Conversation
Strings.toString is tightly coupled to XContentType.JSON which blocks modularizing foundation classes from the server module to the core library. This change refactors the Strings.toString API to accept a generic MediaType such that the toString implementation detail is encapsulated to the :server module. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Gradle Check (Jenkins) Run Completed with:
|
|
Hey @nknize, seems like it failed on a related error:
|
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6414 +/- ##
============================================
+ Coverage 70.34% 70.36% +0.01%
- Complexity 59187 59228 +41
============================================
Files 4798 4798
Lines 284176 284178 +2
Branches 41313 41313
============================================
+ Hits 199899 199952 +53
+ Misses 67562 67471 -91
- Partials 16715 16755 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…nsearch-project#6009) (opensearch-project#6414)" This reverts commit c4ab236. Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Backport 1f4cdd2 from #6009