Skip to content

[Backport] [2.x] Use BuildParams.isCi() instead of checking env var (#5368)#5372

Merged
andrross merged 1 commit intoopensearch-project:2.xfrom
reta:backport/backport-5368-to-2.x
Nov 25, 2022
Merged

[Backport] [2.x] Use BuildParams.isCi() instead of checking env var (#5368)#5372
andrross merged 1 commit intoopensearch-project:2.xfrom
reta:backport/backport-5368-to-2.x

Conversation

@reta
Copy link
Copy Markdown
Contributor

@reta reta commented Nov 24, 2022

Backport of #5368 to 2.x

…t#5368)

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
@reta reta requested a review from andrross November 24, 2022 14:58
@reta reta requested a review from a team as a code owner November 24, 2022 14:58
@reta reta added backport PRs or issues specific to backporting features or enhancments and removed backlog labels Nov 24, 2022
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchCancellationIT.testCancellationDuringFetchPhaseUsingRequestParameter

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 24, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.76%. Comparing base (05979b4) to head (2bfe7b2).
⚠️ Report is 2617 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #5372      +/-   ##
============================================
+ Coverage     70.67%   70.76%   +0.08%     
- Complexity    58335    58398      +63     
============================================
  Files          4701     4701              
  Lines        279131   279131              
  Branches      40753    40753              
============================================
+ Hits         197271   197519     +248     
+ Misses        65376    65143     -233     
+ Partials      16484    16469      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dreamer-89
Copy link
Copy Markdown
Member

Backport (pull_request_target) workflow is failing with below error. I tried to re-run but it fails instantly with same error. The original PR is already merged into main.
@VachaShah : Do you know why is this failing ?

Error: Error: For security reasons, this action should only run on merged PRs.

@andrross andrross merged commit 4b991dd into opensearch-project:2.x Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PRs or issues specific to backporting features or enhancments skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants