Cleanup unused code in org.opensearch.common#5288
Merged
dblock merged 1 commit intoopensearch-project:mainfrom Nov 17, 2022
adnapibar:cleanup-oo-common
Merged
Cleanup unused code in org.opensearch.common#5288dblock merged 1 commit intoopensearch-project:mainfrom adnapibar:cleanup-oo-common
dblock merged 1 commit intoopensearch-project:mainfrom
adnapibar:cleanup-oo-common
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
|
Rebase, these gradle failures should clean themselves up. |
dreamer-89
approved these changes
Nov 17, 2022
Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Member
I think this is transient while we increment versions, but I could be wrong. |
Contributor
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5288 +/- ##
============================================
- Coverage 71.02% 70.92% -0.11%
+ Complexity 58237 58108 -129
============================================
Files 4705 4704 -1
Lines 277480 277459 -21
Branches 40181 40178 -3
============================================
- Hits 197082 196789 -293
- Misses 64288 64583 +295
+ Partials 16110 16087 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dblock
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These are unused internal code in the
org.opensearch.commonpackage.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com