Addressing 'org.apache.hc.core5.http.ParseException: Invalid protocol version' under JDK 16+ #4827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version' under JDK 16+ Signed-off-by: Andriy Redko <[email protected]>
reta
force-pushed
the
fix.jdk.17.tls.factory
branch
from
803855c to
a9ed595
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dblock
approved these changes
Oct 19, 2022
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
This is all the same setTlsDetailsFactory code. Want to refactor the default implementation for TlsStrategy into a helper?
CHANGELOG.md
Outdated
| - Fix decommission status update to non leader nodes ([4800](https://github.com/opensearch-project/OpenSearch/pull/4800)) | ||
| - Fix recovery path for searchable snapshots ([4813](https://github.com/opensearch-project/OpenSearch/pull/4813)) | ||
| - Fix bug in AwarenessAttributeDecommissionIT([4822](https://github.com/opensearch-project/OpenSearch/pull/4822)) | ||
| - Addressing 'org.apache.hc.core5.http.ParseException: Invalid protocol version' under JDK 16+ ([#4827](https://github.com/opensearch-project/OpenSearch/pull/4827)) |
| HttpAsyncClientBuilder httpClientBuilder) { | ||
| final TlsStrategy tlsStrategy = ClientTlsStrategyBuilder.create() | ||
| .setSslContext(sslContext) | ||
| // See please https://issues.apache.org/jira/browse/HTTPCLIENT-2219 |
Contributor
Author
I don't know to be honest (I don't see much value out of it), that's not the kind of helper one wants to make public (since it is used in a few modules and packages), more like workaround |
Signed-off-by: Andriy Redko <[email protected]>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dblock
approved these changes
Oct 19, 2022
andrross
approved these changes
Oct 19, 2022
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
… version' under JDK 16+ (opensearch-project#4827) * Addressing 'org.apache.hc.core5.http.ParseException: Invalid protocol version' under JDK 16+ Signed-off-by: Andriy Redko <[email protected]> * Addressing code review comments Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko [email protected]
Description
When using JDK 16+, the
org.apache.hc.core5.http.ParseException: Invalid protocol versionis being thrown.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.