Skip to content

Conversation

@navneet1v
Copy link
Contributor

@navneet1v navneet1v commented Aug 9, 2022

Description

Refactors the GeoBoundsAggregation for geo_point types from the core server to the geo module

Signed-off-by: Navneet Verma [email protected]

This is the backport PR created for 2.x branch.

Original PR: #3992

Backporting needed manual intervention as there were breaking changes(#4034). The breaking change for this PR and upcoming PR is added already in this PR.

Issues Resolved

#3980

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…server to the geo module.

Signed-off-by: Navneet Verma <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Attention: Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.

Project coverage is 70.55%. Comparing base (7062283) to head (2dafb4d).
Report is 2222 commits behind head on 2.x.

Files Patch % Lines
...regations/metrics/AbstractGeoBoundsAggregator.java 56.52% 16 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #4179      +/-   ##
============================================
+ Coverage     70.45%   70.55%   +0.10%     
- Complexity    56690    56785      +95     
============================================
  Files          4563     4564       +1     
  Lines        273024   273023       -1     
  Branches      40059    40058       -1     
============================================
+ Hits         192364   192644     +280     
+ Misses        64521    64243     -278     
+ Partials      16139    16136       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nknize nknize added the v2.3.0 'Issues and PRs related to version v2.3.0' label Aug 15, 2022
@nknize nknize changed the title Refactors the GeoBoundsAggregation for geo_point types from the core server to the geo module [Backport 2.x] Refactors the GeoBoundsAggregation for geo_point types from the core server to the geo module Aug 15, 2022
@nknize nknize changed the title [Backport 2.x] Refactors the GeoBoundsAggregation for geo_point types from the core server to the geo module [Backport 2.x] Refactors the GeoBoundsAggregation for geo_point types from the core server to the geo module (#3992) Aug 15, 2022
@nknize nknize merged commit c7a4d1d into opensearch-project:2.x Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geospatial Plugins Search:Aggregations v2.3.0 'Issues and PRs related to version v2.3.0'

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants