Add DecommissionService and helper to execute awareness attribute decommissioning #4084
+2,226
−3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| */ | ||
|
|
||
| package org.opensearch.cluster.decommission; | ||
|
|
||
| import org.opensearch.common.io.stream.StreamInput; | ||
| import org.opensearch.common.io.stream.StreamOutput; | ||
| import org.opensearch.common.io.stream.Writeable; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * {@link DecommissionAttribute} encapsulates information about decommissioned node attribute like attribute name, attribute value. | ||
| * | ||
| * @opensearch.internal | ||
| */ | ||
| public final class DecommissionAttribute implements Writeable { | ||
|
There was a problem hiding this comment. this seems to be a generic Attribute class, nothing specific to Decommissioning. Also in the code base today node level attributes are referenced using simple Map<String, String> would that suffice here as well? There was a problem hiding this comment. Added this attribute class for simplicity and clarity. This is helping the code become more readable. Also, in future if the user just wants to decommission a set of nodes with a particular attribute, we would be easily able to modify this class. Similarly, there could be multiple such cases There was a problem hiding this comment. I still feel you don't need a new class for it, just need to store key/ value pair. |
||
| private final String attributeName; | ||
| private final String attributeValue; | ||
|
|
||
| /** | ||
| * Constructs new decommission attribute name value pair | ||
| * | ||
| * @param attributeName attribute name | ||
| * @param attributeValue attribute value | ||
| */ | ||
| public DecommissionAttribute(String attributeName, String attributeValue) { | ||
| this.attributeName = attributeName; | ||
| this.attributeValue = attributeValue; | ||
| } | ||
|
|
||
| /** | ||
| * Returns attribute name | ||
| * | ||
| * @return attributeName | ||
| */ | ||
| public String attributeName() { | ||
| return this.attributeName; | ||
| } | ||
|
|
||
| /** | ||
| * Returns attribute value | ||
| * | ||
| * @return attributeValue | ||
| */ | ||
| public String attributeValue() { | ||
| return this.attributeValue; | ||
| } | ||
|
|
||
| public DecommissionAttribute(StreamInput in) throws IOException { | ||
| attributeName = in.readString(); | ||
| attributeValue = in.readString(); | ||
| } | ||
|
|
||
| /** | ||
| * Writes decommission attribute name value to stream output | ||
| * | ||
| * @param out stream output | ||
| */ | ||
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeString(attributeName); | ||
| out.writeString(attributeValue); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
|
|
||
| DecommissionAttribute that = (DecommissionAttribute) o; | ||
|
|
||
| if (!attributeName.equals(that.attributeName)) return false; | ||
| return attributeValue.equals(that.attributeValue); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(attributeName, attributeValue); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DecommissionAttribute{" + "attributeName='" + attributeName + '\'' + ", attributeValue='" + attributeValue + '\'' + '}'; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: DECOMMISSION_FAILED_EXCEPTION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it
DECOMMISSION_FAILED_EXCEPTIONbut @shwetathareja suggested to change it toDECOMMISSIONING_FAILED_EXCEPTION