Skip to content

Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rishikesh1159 merged 3 commits into from
Jul 8, 2022
Merged

Removing Incorrect heading of breaking changes in 2.1.0 release notes #3817

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a80bf33
Removing Incorrect heading of release notes and removing a PR which w…
Rishikesh1159 Jul 7, 2022
70b2bdf
Removing unnecessary categories
Rishikesh1159 Jul 8, 2022
63df4aa
Removing unnecessary categories and move commits to other categories
Rishikesh1159 Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions release-notes/opensearch.release-notes-2.1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
## 2022-07-07 Version 2.1.0 Release Notes


### Breaking Changes in 2.1.0

#### Remove Mapping types
### Remove Mapping types

@gaiksaya gaiksaya Jul 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a category but rather under some category. More details: https://github.com/opensearch-project/opensearch-plugins/blob/main/RELEASE_NOTES.md#categories
same applies to all below major headings (upgrades, deprecations)

@Rishikesh1159 Rishikesh1159 Jul 7, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Let me change their categories

@peterzhuamazon peterzhuamazon Jul 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not a breaking change can we please put it to either bug fixes or enhancements?

@Rishikesh1159 Rishikesh1159 Jul 8, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that makes sense


* [Type removal] Remove type from BulkRequestParser (#3423) ([#3431](https://github.com/opensearch-project/opensearch/pull/3431))
* [Type removal] _type removal from tests of yaml tests (#3406) ([#3414](https://github.com/opensearch-project/opensearch/pull/3414)
* [Type removal] _type removal from tests of yaml tests (#3406) ([#3414](https://github.com/opensearch-project/opensearch/pull/3414))
* [Backport 2.x] Add type mapping removal bwc tests for indexing, searching, snapshots ([#2921](https://github.com/opensearch-project/opensearch/pull/2921))

#### Upgrades
### Upgrades

* Lock 2.1 release to Lucene 9.2.0. ([#3676](https://github.com/opensearch-project/opensearch/pull/3676))


#### Deprecations
### Deprecations

* [2.x] Deprecate public methods and variables with master term in package 'org.opensearch.action.support.master' (#3617) ([#3643](https://github.com/opensearch-project/opensearch/pull/3643))
* Deprecate classes in org.opensearch.action.support.master (#3593) ([#3609](https://github.com/opensearch-project/opensearch/pull/3609))
Expand Down Expand Up @@ -67,7 +63,6 @@
* Removing unused method from TransportSearchAction (#3437) ([#3445](https://github.com/opensearch-project/opensearch/pull/3445))
* Fix Lucene-snapshots repo for jdk 17. (#3396) ([#3404](https://github.com/opensearch-project/opensearch/pull/3404))
* Temporary adding Apache Lucene repositories for snapshots (#3042) ([#3047](https://github.com/opensearch-project/opensearch/pull/3047))
* [Remove] MainResponse version override cluster setting (#3031) ([#3032](https://github.com/opensearch-project/opensearch/pull/3032))

@dreamer-89 dreamer-89 Jul 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing to previous minor relesae (2.0) this change was missing and added back in patch 2.0.1. So, if we are basing changes on 2.0, we should include it.

@mch2 mch2 Jul 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3530 is missing here then that reverts this removal.

@Rishikesh1159 Rishikesh1159 Jul 8, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @mch2 mentioned #3530 reverts this change. Discussed offline with @mch2 decided to leave out this commit

* Excluding system indices from max shard limit validator (#2894) ([#2911](https://github.com/opensearch-project/opensearch/pull/2911))
* [Backport] [2.x] Bugfix to guard against stack overflow errors caused by very large reg-ex input ([#2817](https://github.com/opensearch-project/opensearch/pull/2817))

Expand Down