Skip to content

Conversation

@bharath-techie
Copy link
Contributor

Description

Merging changes to feature branch

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Here is the PR diff and fb branch diff against main - they have exact same amount of files and lines changes - hence the rebase is proper.

Screenshot 2022-06-27 at 12 30 33 PM

Screenshot 2022-06-27 at 12 30 28 PM

dependabot bot and others added 30 commits May 18, 2022 16:51
…azure (opensearch-project#3360)

* Bump reactor-netty-core in /plugins/repository-azure

Bumps [reactor-netty-core](https://github.com/reactor/reactor-netty) from 1.0.16 to 1.0.19.
- [Release notes](https://github.com/reactor/reactor-netty/releases)
- [Commits](reactor/reactor-netty@v1.0.16...v1.0.19)

---
updated-dependencies:
- dependency-name: io.projectreactor.netty:reactor-netty-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…rocessor (opensearch-project#3239)

* [Type removal] Remove _type deprecation from script and conditional processor

Signed-off-by: Suraj Singh <[email protected]>

* Spotless check apply

Signed-off-by: Suraj Singh <[email protected]>
…stants (opensearch-project#3372)

* [Type removal] Remove redundant _type deprecation checks in bulk request

Signed-off-by: Suraj Singh <[email protected]>

* [Type removal] bulk yaml tests validating deprecation on _type and removal from scripts

Signed-off-by: Suraj Singh <[email protected]>
…ject#3406)

* [Type removal] _type removal from tests of yaml tests

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless failures

Signed-off-by: Suraj Singh <[email protected]>

* Fix assertion failures

Signed-off-by: Suraj Singh <[email protected]>

* Fix assertion failures in DoSectionTests

Signed-off-by: Suraj Singh <[email protected]>
Upgrades to latest snapshot of lucene 9.2.0 in preparation for GA release.

Signed-off-by: Nicholas Walter Knize <[email protected]>
This change removes some old commits from the 2.0.0-rc1 release notes. These commits were already released as part of 1.x releases.

Add back some missing type removal commits to the 2.0.0 release notes

Signed-off-by: Rabi Panda <[email protected]>
Bumps Version.V_2_1_0 lucene version to 9.2 after backporting upgrage.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Bumps com.gradle.enterprise from 3.10 to 3.10.1.

---
updated-dependencies:
- dependency-name: com.gradle.enterprise
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pensearch-project#3427)

Bumps [reactor-core](https://github.com/reactor/reactor-core) from 3.4.17 to 3.4.18.
- [Release notes](https://github.com/reactor/reactor-core/releases)
- [Commits](reactor/reactor-core@v3.4.17...v3.4.18)

---
updated-dependencies:
- dependency-name: io.projectreactor:reactor-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…pensearch-project#3426)

Bumps [gax-httpjson](https://github.com/googleapis/gax-java) from 0.101.0 to 0.103.1.
- [Release notes](https://github.com/googleapis/gax-java/releases)
- [Changelog](https://github.com/googleapis/gax-java/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/gax-java/commits)

---
updated-dependencies:
- dependency-name: com.google.api:gax-httpjson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…gment replication and recovery code paths (opensearch-project#3234)

* RecoveryState inherits from ReplicationState + RecoveryTarget inherits from ReplicationTarget

Signed-off-by: Poojita Raj <[email protected]>

* Refactoring: mixedClusterVersion error fix + move Stage to ReplicationState

Signed-off-by: Poojita Raj <[email protected]>

* pull ReplicationListener into a top level class + add javadocs + address review comments

Signed-off-by: Poojita Raj <[email protected]>

* fix javadoc

Signed-off-by: Poojita Raj <[email protected]>

* review changes

Signed-off-by: Poojita Raj <[email protected]>

* Refactoring the hierarchy relationship between repl and recovery

Signed-off-by: Poojita Raj <[email protected]>

* style fix

Signed-off-by: Poojita Raj <[email protected]>

* move package common under replication

Signed-off-by: Poojita Raj <[email protected]>

* rename to replication

Signed-off-by: Poojita Raj <[email protected]>

* rename and doc changes

Signed-off-by: Poojita Raj <[email protected]>
…#3423)

* [Type removal] Remove type handling in bulk request parser

Signed-off-by: Suraj Singh <[email protected]>

* [Type removal] Remove testTypesStillParsedForBulkMonitoring as it is no longer present in codebase

Signed-off-by: Suraj Singh <[email protected]>
…is turned on and Primary shard refreshes (opensearch-project#3108)

* Intial PR adding classes and tests related to checkpoint publishing

Signed-off-by: Rishikesh1159 <[email protected]>

* Putting a Draft PR with all changes in classes. Testing is still not included in this commit.

Signed-off-by: Rishikesh1159 <[email protected]>

* Wiring up index shard to new engine, spotless apply and removing unnecessary tests and logs

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding Unit test for checkpointRefreshListener

Signed-off-by: Rishikesh1159 <[email protected]>

* Applying spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Fixing import statements *

Signed-off-by: Rishikesh1159 <[email protected]>

* removing unused constructor in index shard

Signed-off-by: Rishikesh1159 <[email protected]>

* Addressing comments from last commit

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding package-info.java files for two new packages

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding test for null checkpoint publisher and addreesing PR comments

Signed-off-by: Rishikesh1159 <[email protected]>

* Add docs for indexshardtests and remove shard.refresh

Signed-off-by: Rishikesh1159 <[email protected]>
… enabled. (opensearch-project#3240)

* Change fastForwardProcessedSeqNo method in LocalCheckpointTracker to persisted checkpoint.

This change inverts fastForwardProcessedSeqNo to fastForwardPersistedSeqNo for use in
Segment Replication.  This is so that a Segrep Engine can match the logic of InternalEngine
where the seqNo is incremented with each operation, but only persisted in the tracker on a flush.
With Segment Replication we bump the processed number with each operation received index/delete/noOp, and
invoke this method when we receive a new set of segments to bump the persisted seqNo.

Signed-off-by: Marc Handalian <[email protected]>

* Extract Translog specific engine methods into an abstract class.

This change extracts translog specific methods to an abstract engine class so that other engine
implementations can reuse translog logic.

Signed-off-by: Marc Handalian <[email protected]>

* Add a separate Engine implementation for replicas with segment replication enabled.

This change adds a new engine intended to be used on replicas with segment replication enabled.
This engine does not wire up an IndexWriter, but still writes all operations to a translog.
The engine uses a new ReaderManager that refreshes from an externally provided SegmentInfos.

Signed-off-by: Marc Handalian <[email protected]>

* Fix spotless checks.

Signed-off-by: Marc Handalian <[email protected]>

* Fix :server:compileInternalClusterTestJava compilation.

Signed-off-by: Marc Handalian <[email protected]>

* Fix failing test naming convention check.

Signed-off-by: Marc Handalian <[email protected]>

* PR feedback.

- Removed isReadOnlyReplica from overloaded constructor and added feature flag checks.
- Updated log msg in NRTReplicationReaderManager
- cleaned up store ref counting in NRTReplicationEngine.

Signed-off-by: Marc Handalian <[email protected]>

* Fix spotless check.

Signed-off-by: Marc Handalian <[email protected]>

* Remove TranslogAwareEngine and build translog in NRTReplicationEngine.

Signed-off-by: Marc Handalian <[email protected]>

* Fix formatting

Signed-off-by: Marc Handalian <[email protected]>

* Add missing translog methods to NRTEngine.

Signed-off-by: Marc Handalian <[email protected]>

* Remove persistent seqNo check from fastForwardProcessedSeqNo.

Signed-off-by: Marc Handalian <[email protected]>

* PR feedback.

Signed-off-by: Marc Handalian <[email protected]>

* Add test specific to translog trimming.

Signed-off-by: Marc Handalian <[email protected]>

* Javadoc check.

Signed-off-by: Marc Handalian <[email protected]>

* Add failEngine calls to translog methods in NRTReplicationEngine.
Roll xlog generation on replica when a new commit point is received.

Signed-off-by: Marc Handalian <[email protected]>
…oject#3359)

Bumps hadoop-minicluster from 3.3.2 to 3.3.3.

---
updated-dependencies:
- dependency-name: org.apache.hadoop:hadoop-minicluster
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ch-project#3358)

* Bump avro from 1.10.2 to 1.11.0 in /plugins/repository-hdfs

Bumps avro from 1.10.2 to 1.11.0.

---
updated-dependencies:
- dependency-name: org.apache.avro:avro
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updating SHAs

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…ry (opensearch-project#2520)

* Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable/method/class names, in `server/src/test` directory.
* Backwards compatibility is not impacted.
* Add a new unit test `testDeprecatedMasterNodeFilter()` to validate using `master:true` or `master:false` can filter the node in [Cluster Stats](https://opensearch.org/docs/latest/opensearch/rest-api/cluster-stats/) API, after the `master` role is deprecated in PR opensearch-project#2424

Signed-off-by: Tianli Feng <[email protected]>
…#3437)

* Removing unused method from TransportSearchAction

Signed-off-by: Ankit Jain <[email protected]>
…roject#1901). (opensearch-project#3119)

* Set term vector flags to false for ._index_prefix field (opensearch-project#1901).

Signed-off-by: Vesa Pehkonen <[email protected]>

* Replaced the FieldType copy ctor with ctor for the prefix field and replaced
setting the field type parameters with setIndexOptions(). (opensearch-project#1901)

Signed-off-by: Vesa Pehkonen <[email protected]>

* Added tests for term vectors. (opensearch-project#1901)

Signed-off-by: Vesa Pehkonen <[email protected]>

* Fixed code formatting error.

Signed-off-by: Vesa Pehkonen <[email protected]>

Co-authored-by: sdp <[email protected]>
…essageOnlyOnes when cgroups are available but cgroup stats is not (opensearch-project#3448)

Signed-off-by: Andriy Redko <[email protected]>
…ate replication events. (opensearch-project#3439)

* Add SegmentReplicationTargetService to orchestrate replication events.

This change introduces  boilerplate classes for Segment Replication and a target service
to orchestrate replication events.

It also includes two refactors of peer recovery components for reuse.
1. Rename RecoveryFileChunkRequest to FileChunkRequest and extract code to handle throttling into
ReplicationTarget.
2. Extracts a component to execute retryable requests over the transport layer.

Signed-off-by: Marc Handalian <[email protected]>

* Code cleanup.

Signed-off-by: Marc Handalian <[email protected]>

* Make SegmentReplicationTargetService component final so that it can not
be extended by plugins.

Signed-off-by: Marc Handalian <[email protected]>
…ry-azure (opensearch-project#3474)

Bumps [azure-core-http-netty](https://github.com/Azure/azure-sdk-for-java) from 1.11.9 to 1.12.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-core-http-netty_1.11.9...azure-core_1.12.0)

---
updated-dependencies:
- dependency-name: com.azure:azure-core-http-netty
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
mch2 and others added 18 commits June 17, 2022 13:51
…rm file copy. (opensearch-project#3525)

* Add components for segment replication to perform file copy.

This change adds the required components to SegmentReplicationSourceService to initiate copy and react to lifecycle events.
Along with new components it refactors common file copy code from RecoverySourceHandler into reusable pieces.

Signed-off-by: Marc Handalian <[email protected]>
…rg.opensearch.action.support.master' (opensearch-project#3617)

Signed-off-by: Tianli Feng <[email protected]>
…3533)

* implement segment replication target

Signed-off-by: Poojita Raj <[email protected]>

* test added

Signed-off-by: Poojita Raj <[email protected]>

* changes to tests + finalizeReplication

Signed-off-by: Poojita Raj <[email protected]>

* fix style check

Signed-off-by: Poojita Raj <[email protected]>

* addressing comments + fix gradle check

Signed-off-by: Poojita Raj <[email protected]>

* added test + addressed review comments

Signed-off-by: Poojita Raj <[email protected]>
…ply (opensearch-project#3626)

* [BUG] opensearch crashes on closed client connection before search reply

Signed-off-by: Andriy Redko <[email protected]>

* Addressing code review comments

Signed-off-by: Andriy Redko <[email protected]>
…pensearch-project#3638)

* Introduce decoupled translog manager interfaces

Signed-off-by: Bukhtawar Khan <[email protected]>
…ment Replication is turned on (opensearch-project#3540)

* Adding onNewCheckpoint and it's test to start replication. SCheck for latestcheckpoint and replaying logic is removed from this commit and will be added in a different PR

Signed-off-by: Rishikesh1159 <[email protected]>

* Changing binding/inject logic and addressing comments from PR

Signed-off-by: Rishikesh1159 <[email protected]>

* Applying spotless check

Signed-off-by: Rishikesh1159 <[email protected]>

* Moving shouldProcessCheckpoint() to IndexShard, and removing some trace logs

Signed-off-by: Rishikesh1159 <[email protected]>

* applying spotlessApply

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding more info to log statement in targetservice class

Signed-off-by: Rishikesh1159 <[email protected]>

* applying spotlessApply

Signed-off-by: Rishikesh1159 <[email protected]>

* Addressing comments on PR

Signed-off-by: Rishikesh1159 <[email protected]>

* Adding teardown() in SegmentReplicationTargetServiceTests.

Signed-off-by: Rishikesh1159 <[email protected]>

* fixing testShouldProcessCheckpoint() in SegmentReplicationTargetServiceTests

Signed-off-by: Rishikesh1159 <[email protected]>

* Removing CheckpointPublisherProvider in IndicesModule

Signed-off-by: Rishikesh1159 <[email protected]>

* spotless check apply

Signed-off-by: Rishikesh1159 <[email protected]>
opensearch-project#3662)

* Remove class org.opensearch.action.support.master.AcknowledgedResponse

Signed-off-by: Tianli Feng <[email protected]>

* Remove class org.opensearch.action.support.master.AcknowledgedRequest RequestBuilder ShardsAcknowledgedResponse

Signed-off-by: Tianli Feng <[email protected]>
…tags (url, scm) (opensearch-project#3656)

* [BUG] Custom POM configuration for ZIP publication produces duplicit tags (url, scm)

Signed-off-by: Andriy Redko <[email protected]>

* Added test case for pluginZip with POM

Signed-off-by: Andriy Redko <[email protected]>

* Support both Gradle 6.8.x and Gradle 7.4.x

Signed-off-by: Andriy Redko <[email protected]>
@bharath-techie bharath-techie force-pushed the fb branch 2 times, most recently from c3139e2 to 024e9bb Compare June 27, 2022 07:10
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c3139e2642438cec9209b8cdfa61e667133fe677
Log 6355

Reports 6355

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 024e9bb435ebc1cdc817e90b7de7491a111b67b2
Log 6356

Reports 6356

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9b12d89
Log 6357

Reports 6357

@Bukhtawar Bukhtawar marked this pull request as ready for review June 27, 2022 09:09
@Bukhtawar Bukhtawar requested review from a team and reta as code owners June 27, 2022 09:09
Copy link
Contributor

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too hard to review I am merging this to feature branch and later we can cherry pick to main

@Bukhtawar Bukhtawar merged commit 15fe7e7 into opensearch-project:feature/point_in_time Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.