Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.0] [Javadocs] add to o.o.search.rescore,searchafter,slice, sort, and suggest #3267

Merged
merged 1 commit into from
May 10, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3b71ea6 from #3264

…gest (#3264)

Adds class level javadocs to org.opensearch.search, and
org.opensearch.search.rescore, searchAfter, slice, sort, and suggest
subpackages.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 3b71ea6)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner May 9, 2022 23:21
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5907025
Log 5186

Reports 5186

@kartg
Copy link
Member

kartg commented May 10, 2022

Manually overriding DCO failure due to name mismatch:

Expected "Nick Knize.... but got "Nicholas .....".

@dblock
Copy link
Member

dblock commented May 10, 2022

@nknize I know you don't want to change names between different places, but this hits us every time on this project, and requires the code reviewer to hit "set DCO to pass" manually, maybe you can help resolve it with the correct fix?

@dblock dblock merged commit c713ae8 into 2.0 May 10, 2022
@github-actions github-actions bot deleted the backport/backport-3264-to-2.0 branch May 10, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants