[Backport 2.19] Disable Mustache partial template resolution in CustomMustacheFactory - #22440
Merged
cwperks merged 1 commit intoJul 10, 2026
Conversation
…opensearch-project#22438) Override getReader() in CustomMustacheFactory to throw MustacheException when a partial template ({{>name}}) is encountered at compile time. Search templates in OpenSearch are self-contained inline strings, so partial resolution has no legitimate use. Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit e1fa8aa) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
cwperks
approved these changes
Jul 10, 2026
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.19 #22440 +/- ##
============================================
+ Coverage 71.92% 72.13% +0.20%
+ Complexity 66009 64557 -1452
============================================
Files 5342 5120 -222
Lines 307392 300201 -7191
Branches 44862 44090 -772
============================================
- Hits 221105 216555 -4550
+ Misses 67823 65459 -2364
+ Partials 18464 18187 -277 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport e1fa8aa from #22438.