Revert "Add indexing throttle on merge pressure for DataFormatAwareEngine (#22319) - #22335
Merged
mgodwan merged 1 commit intoJun 28, 2026
Merged
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit fba4d70)Here are some key observations to aid the review process:
|
Contributor
|
❌ Gradle check result for 4d5e4d7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…gine (opensearch-project#22319)" This reverts commit 86d0f52. Signed-off-by: rayshrey <rayshrey@amazon.com>
rayshrey
force-pushed
the
merge-index-throttle-revert
branch
from
June 27, 2026 20:26
4d5e4d7 to
fba4d70
Compare
Contributor
|
Persistent review updated to latest commit fba4d70 |
mgodwan
marked this pull request as ready for review
June 27, 2026 20:54
mgodwan
requested review from
a team,
Bukhtawar,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
June 27, 2026 20:54
mgodwan
approved these changes
Jun 27, 2026
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22335 +/- ##
============================================
- Coverage 73.37% 73.35% -0.02%
- Complexity 76063 76078 +15
============================================
Files 6076 6076
Lines 345517 345494 -23
Branches 49733 49729 -4
============================================
- Hits 253528 253454 -74
- Misses 71792 71816 +24
- Partials 20197 20224 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KhishorekumarBS
pushed a commit
to KhishorekumarBS/OpenSearch
that referenced
this pull request
Jul 3, 2026
…gine (opensearch-project#22319)" (opensearch-project#22335) This reverts commit 86d0f52. Signed-off-by: rayshrey <rayshrey@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 86d0f52.
The reason behind reverting is that we are observing a drop in indexing performance due to continuous throttling from merges due to the throttling mechanism introduced in the mentioned commit.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.