Bump version to 3.8 - #22090
Conversation
PR Reviewer Guide 🔍(Review updated until commit b997a3d)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to b997a3d
Previous suggestionsSuggestions up to commit c30fe8e
|
|
❌ Gradle check result for c30fe8e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Andrew Ross <andrross@amazon.com>
|
Persistent review updated to latest commit b997a3d |
|
❌ Gradle check result for b997a3d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22090 +/- ##
============================================
+ Coverage 73.37% 73.46% +0.09%
- Complexity 75572 75603 +31
============================================
Files 6038 6038
Lines 343009 343011 +2
Branches 49348 49348
============================================
+ Hits 251674 251992 +318
+ Misses 71305 70944 -361
- Partials 20030 20075 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…SHOT Aligns the local sandbox with the OpenSearch core 3.8 bump (opensearch-project#22090). The SQL plugin and job-scheduler plugin use a four-segment version scheme (major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0. - sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and sqlPlugin zip dependencies pulled from OpenSearch Snapshots. - sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for -PsqlUnifiedQueryVersion (override-able for local sql-repo builds). Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
…SHOT Aligns the local sandbox with the OpenSearch core 3.8 bump (opensearch-project#22090). The SQL plugin and job-scheduler plugin use a four-segment version scheme (major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0. - sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and sqlPlugin zip dependencies pulled from OpenSearch Snapshots. - sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for -PsqlUnifiedQueryVersion (override-able for local sql-repo builds). Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
* Honour Calcite TIMESTAMP precision in QTF stitcher output schema ArrowCalciteTypes.toArrow() hardcoded TimeUnit.MILLISECOND for every Calcite TIMESTAMP, so the late-materialization Stitcher pre-allocated a TimestampMilliVector for the output VSR. Shards correctly emitted Timestamp(NANOSECOND) for date_nanos fields, and Arrow's BaseFixedWidthVector.copyFromSafe requires identical fixed-width subclasses, so it tripped on every shard's response with a message-less IllegalArgumentException — surfacing to clients as HTTP 400 "Invalid Query". Plan shape required to fire: multi-shard parquet-backed index with date_nanos + Timestamp in projection + sort + head N (or other top-K) + at least one fetch-only field above the anchor. Drop any one and the rewriter declines QTF or the bug doesn't fire. Fix: branch on Calcite precision. precision == 9 -> NANOSECOND, else MILLISECOND. BackendPlanAdapter preserves precision through CAST rewrites, so the value is reliable (verified via DEBUG plan dump showing TIMESTAMP(9) survives). - Unit: ArrowCalciteTypesTests adds 3 cases covering precision 3, 9, default. The factory uses an extended RelDataTypeSystemImpl that lifts MAX_DATETIME precision to 9 — default Calcite caps at 3 and would silently clamp the test input. - IT: LateMaterializationDateNanosIT spins a 2-shard parquet+lucene index with date_nanos and runs the q01-style plan (match + sort - ts + head + fetch-only field). Pre-fix: HTTP 400 with the exact bug signature. Post-fix: 4 rows in DESC order with sub-millisecond precision preserved. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * chore: bump opensearch-sql / opensearch-job-scheduler to 3.8.0.0-SNAPSHOT Aligns the local sandbox with the OpenSearch core 3.8 bump (#22090). The SQL plugin and job-scheduler plugin use a four-segment version scheme (major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0. - sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and sqlPlugin zip dependencies pulled from OpenSearch Snapshots. - sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for -PsqlUnifiedQueryVersion (override-able for local sql-repo builds). Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> --------- Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
…project#22095) * Honour Calcite TIMESTAMP precision in QTF stitcher output schema ArrowCalciteTypes.toArrow() hardcoded TimeUnit.MILLISECOND for every Calcite TIMESTAMP, so the late-materialization Stitcher pre-allocated a TimestampMilliVector for the output VSR. Shards correctly emitted Timestamp(NANOSECOND) for date_nanos fields, and Arrow's BaseFixedWidthVector.copyFromSafe requires identical fixed-width subclasses, so it tripped on every shard's response with a message-less IllegalArgumentException — surfacing to clients as HTTP 400 "Invalid Query". Plan shape required to fire: multi-shard parquet-backed index with date_nanos + Timestamp in projection + sort + head N (or other top-K) + at least one fetch-only field above the anchor. Drop any one and the rewriter declines QTF or the bug doesn't fire. Fix: branch on Calcite precision. precision == 9 -> NANOSECOND, else MILLISECOND. BackendPlanAdapter preserves precision through CAST rewrites, so the value is reliable (verified via DEBUG plan dump showing TIMESTAMP(9) survives). - Unit: ArrowCalciteTypesTests adds 3 cases covering precision 3, 9, default. The factory uses an extended RelDataTypeSystemImpl that lifts MAX_DATETIME precision to 9 — default Calcite caps at 3 and would silently clamp the test input. - IT: LateMaterializationDateNanosIT spins a 2-shard parquet+lucene index with date_nanos and runs the q01-style plan (match + sort - ts + head + fetch-only field). Pre-fix: HTTP 400 with the exact bug signature. Post-fix: 4 rows in DESC order with sub-millisecond precision preserved. Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * chore: bump opensearch-sql / opensearch-job-scheduler to 3.8.0.0-SNAPSHOT Aligns the local sandbox with the OpenSearch core 3.8 bump (opensearch-project#22090). The SQL plugin and job-scheduler plugin use a four-segment version scheme (major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0. - sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and sqlPlugin zip dependencies pulled from OpenSearch Snapshots. - sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for -PsqlUnifiedQueryVersion (override-able for local sql-repo builds). Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> --------- Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
This depends on the 3.7.1 version bump on the 3.7 branch in #22089
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.