Skip to content

Bump version to 3.8 - #22090

Merged
cwperks merged 1 commit into
opensearch-project:mainfrom
andrross:main-3.8
Jun 10, 2026
Merged

Bump version to 3.8#22090
cwperks merged 1 commit into
opensearch-project:mainfrom
andrross:main-3.8

Conversation

@andrross

@andrross andrross commented Jun 9, 2026

Copy link
Copy Markdown
Member

This depends on the 3.7.1 version bump on the 3.7 branch in #22089

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross
andrross requested a review from a team as a code owner June 9, 2026 21:28
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit b997a3d)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Latest suggestions up to b997a3d
Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Missing BWC version entry

The version constant V_3_7_1 is defined but not added to the BWC versions list in
.ci/bwcVersions. This could cause backward compatibility testing issues. Ensure all
intermediate patch versions are included in the BWC configuration.

libs/core/src/main/java/org/opensearch/Version.java [175-177]

+public static final Version V_3_7_1 = new Version(3070199, org.apache.lucene.util.Version.LUCENE_10_4_0);
+public static final Version V_3_8_0 = new Version(3080099, org.apache.lucene.util.Version.LUCENE_10_4_0);
+public static final Version CURRENT = V_3_8_0;
 
-
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that V_3_7_1 is defined in the Version.java file but not added to the .ci/bwcVersions file, which could impact backward compatibility testing. However, this is a verification request rather than a code fix, and the existing_code and improved_code are identical.

Medium

Previous suggestions

Suggestions up to commit c30fe8e
CategorySuggestion                                                                                                                                    Impact
Possible issue
Add missing BWC version entry

The version constant V_3_7_1 is defined but not added to the BWC versions list in
.ci/bwcVersions. This could cause backward compatibility testing issues. Ensure all
intermediate patch versions are included in the BWC configuration.

libs/core/src/main/java/org/opensearch/Version.java [175-177]

+public static final Version V_3_7_1 = new Version(3070199, org.apache.lucene.util.Version.LUCENE_10_4_0);
+public static final Version V_3_8_0 = new Version(3080099, org.apache.lucene.util.Version.LUCENE_10_4_0);
+public static final Version CURRENT = V_3_8_0;
 
-
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that V_3_7_1 is defined in the Version.java file but not added to the BWC versions list in .ci/bwcVersions. This is a valid concern for backward compatibility testing, though the suggestion asks the user to verify/ensure the change rather than providing a concrete fix.

Medium

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for c30fe8e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit b997a3d

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

❌ Gradle check result for b997a3d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions

Copy link
Copy Markdown
Contributor

✅ Gradle check result for b997a3d: SUCCESS

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.46%. Comparing base (1559fb4) to head (b997a3d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #22090      +/-   ##
============================================
+ Coverage     73.37%   73.46%   +0.09%     
- Complexity    75572    75603      +31     
============================================
  Files          6038     6038              
  Lines        343009   343011       +2     
  Branches      49348    49348              
============================================
+ Hits         251674   251992     +318     
+ Misses        71305    70944     -361     
- Partials      20030    20075      +45     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks
cwperks merged commit 81a4bc6 into opensearch-project:main Jun 10, 2026
26 of 28 checks passed
@andrross
andrross deleted the main-3.8 branch June 10, 2026 15:03
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Jun 10, 2026
…SHOT

Aligns the local sandbox with the OpenSearch core 3.8 bump (opensearch-project#22090).
The SQL plugin and job-scheduler plugin use a four-segment version scheme
(major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0.

- sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and
  sqlPlugin zip dependencies pulled from OpenSearch Snapshots.
- sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for
  -PsqlUnifiedQueryVersion (override-able for local sql-repo builds).

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
vinaykpud added a commit to vinaykpud/OpenSearch that referenced this pull request Jun 11, 2026
…SHOT

Aligns the local sandbox with the OpenSearch core 3.8 bump (opensearch-project#22090).
The SQL plugin and job-scheduler plugin use a four-segment version scheme
(major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0.

- sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and
  sqlPlugin zip dependencies pulled from OpenSearch Snapshots.
- sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for
  -PsqlUnifiedQueryVersion (override-able for local sql-repo builds).

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
mch2 pushed a commit that referenced this pull request Jun 11, 2026
* Honour Calcite TIMESTAMP precision in QTF stitcher output schema

ArrowCalciteTypes.toArrow() hardcoded TimeUnit.MILLISECOND for every Calcite
TIMESTAMP, so the late-materialization Stitcher pre-allocated a
TimestampMilliVector for the output VSR. Shards correctly emitted
Timestamp(NANOSECOND) for date_nanos fields, and Arrow's
BaseFixedWidthVector.copyFromSafe requires identical fixed-width subclasses,
so it tripped on every shard's response with a message-less
IllegalArgumentException — surfacing to clients as HTTP 400 "Invalid Query".

Plan shape required to fire: multi-shard parquet-backed index with date_nanos +
Timestamp in projection + sort + head N (or other top-K) + at least one
fetch-only field above the anchor. Drop any one and the rewriter declines QTF
or the bug doesn't fire.

Fix: branch on Calcite precision. precision == 9 -> NANOSECOND, else MILLISECOND.
BackendPlanAdapter preserves precision through CAST rewrites, so the value is
reliable (verified via DEBUG plan dump showing TIMESTAMP(9) survives).

- Unit: ArrowCalciteTypesTests adds 3 cases covering precision 3, 9, default.
  The factory uses an extended RelDataTypeSystemImpl that lifts MAX_DATETIME
  precision to 9 — default Calcite caps at 3 and would silently clamp the test
  input.
- IT: LateMaterializationDateNanosIT spins a 2-shard parquet+lucene index with
  date_nanos and runs the q01-style plan (match + sort - ts + head + fetch-only
  field). Pre-fix: HTTP 400 with the exact bug signature. Post-fix: 4 rows in
  DESC order with sub-millisecond precision preserved.

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

* chore: bump opensearch-sql / opensearch-job-scheduler to 3.8.0.0-SNAPSHOT

Aligns the local sandbox with the OpenSearch core 3.8 bump (#22090).
The SQL plugin and job-scheduler plugin use a four-segment version scheme
(major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0.

- sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and
  sqlPlugin zip dependencies pulled from OpenSearch Snapshots.
- sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for
  -PsqlUnifiedQueryVersion (override-able for local sql-repo builds).

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

---------

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
KhishorekumarBS pushed a commit to KhishorekumarBS/OpenSearch that referenced this pull request Jul 3, 2026
Signed-off-by: Andrew Ross <andrross@amazon.com>
KhishorekumarBS pushed a commit to KhishorekumarBS/OpenSearch that referenced this pull request Jul 3, 2026
…project#22095)

* Honour Calcite TIMESTAMP precision in QTF stitcher output schema

ArrowCalciteTypes.toArrow() hardcoded TimeUnit.MILLISECOND for every Calcite
TIMESTAMP, so the late-materialization Stitcher pre-allocated a
TimestampMilliVector for the output VSR. Shards correctly emitted
Timestamp(NANOSECOND) for date_nanos fields, and Arrow's
BaseFixedWidthVector.copyFromSafe requires identical fixed-width subclasses,
so it tripped on every shard's response with a message-less
IllegalArgumentException — surfacing to clients as HTTP 400 "Invalid Query".

Plan shape required to fire: multi-shard parquet-backed index with date_nanos +
Timestamp in projection + sort + head N (or other top-K) + at least one
fetch-only field above the anchor. Drop any one and the rewriter declines QTF
or the bug doesn't fire.

Fix: branch on Calcite precision. precision == 9 -> NANOSECOND, else MILLISECOND.
BackendPlanAdapter preserves precision through CAST rewrites, so the value is
reliable (verified via DEBUG plan dump showing TIMESTAMP(9) survives).

- Unit: ArrowCalciteTypesTests adds 3 cases covering precision 3, 9, default.
  The factory uses an extended RelDataTypeSystemImpl that lifts MAX_DATETIME
  precision to 9 — default Calcite caps at 3 and would silently clamp the test
  input.
- IT: LateMaterializationDateNanosIT spins a 2-shard parquet+lucene index with
  date_nanos and runs the q01-style plan (match + sort - ts + head + fetch-only
  field). Pre-fix: HTTP 400 with the exact bug signature. Post-fix: 4 rows in
  DESC order with sub-millisecond precision preserved.

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

* chore: bump opensearch-sql / opensearch-job-scheduler to 3.8.0.0-SNAPSHOT

Aligns the local sandbox with the OpenSearch core 3.8 bump (opensearch-project#22090).
The SQL plugin and job-scheduler plugin use a four-segment version scheme
(major.minor.patch.0-SNAPSHOT) tracking core's three-segment 3.8.0.

- sandbox/qa/analytics-engine-rest/build.gradle: jobSchedulerPlugin and
  sqlPlugin zip dependencies pulled from OpenSearch Snapshots.
- sandbox/plugins/test-ppl-frontend/build.gradle: default fallback for
  -PsqlUnifiedQueryVersion (override-able for local sql-repo builds).

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

---------

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants