Skip to content

Mute Broken Sandbox tests - #21774

Merged
mch2 merged 1 commit into
opensearch-project:mainfrom
mch2:vt
May 21, 2026
Merged

Mute Broken Sandbox tests#21774
mch2 merged 1 commit into
opensearch-project:mainfrom
mch2:vt

Conversation

@mch2

@mch2 mch2 commented May 21, 2026

Copy link
Copy Markdown
Member

Description

Mute Broken Sandbox tests

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2
mch2 requested a review from a team as a code owner May 21, 2026 03:53
@github-actions

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit a985b0f.

PathLineSeverityDescription
sandbox/qa/analytics-engine-rest/src/test/java/org/opensearch/analytics/qa/FilterDelegationIT.java34lowMultiple tests are disabled via @LuceneTestCase.AwaitsFix with vague or empty bugUrl values ('broken', ''). While this is a recognized Lucene/OpenSearch pattern for skipping broken tests, the absence of a real tracking URL makes it impossible to verify intent or schedule re-enablement. This is a code-quality concern rather than a direct security threat, but bulk-disabling integration tests without traceability can mask regressions.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 0 | Medium: 0 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Replace placeholder bugUrl with actual issue

The bugUrl parameter contains a placeholder value "broken" instead of a valid bug
tracking URL. This makes it difficult to track the actual issue and understand when
the test should be re-enabled. Replace with a proper issue tracker URL or ticket
number.

sandbox/qa/analytics-engine-coordinator/src/internalClusterTest/java/org/opensearch/analytics/resilience/CoordinatorTopologyTestBase.java [48-49]

-@LuceneTestCase.AwaitsFix(bugUrl = "broken")
+@LuceneTestCase.AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/XXXXX")
 public abstract class CoordinatorTopologyTestBase extends OpenSearchIntegTestCase {
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that the bugUrl parameter contains a placeholder value "broken" instead of a proper issue tracker URL. This is important for test maintenance and tracking, though it doesn't affect code functionality.

Medium
Provide valid bugUrl for muted test

The bugUrl parameter is empty, which provides no information about the underlying
issue. This makes it impossible to track the bug or determine when the test should
be re-enabled. Provide a valid bug tracking URL or ticket number.

sandbox/qa/analytics-engine-rest/src/test/java/org/opensearch/analytics/qa/FilterDelegationIT.java [34-35]

-@LuceneTestCase.AwaitsFix(bugUrl = "")
+@LuceneTestCase.AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/XXXXX")
 public class FilterDelegationIT extends AnalyticsRestTestCase {
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that the bugUrl parameter is empty, which provides no tracking information for the disabled test. This is important for test maintenance but doesn't impact code execution.

Medium

@mch2
mch2 merged commit ca22376 into opensearch-project:main May 21, 2026
14 of 15 checks passed
@mch2
mch2 deleted the vt branch May 21, 2026 04:40
sandeshkr419 added a commit that referenced this pull request May 30, 2026
These four tests were muted by #21774 right after #21731 introduced
them. The underlying aggCall slot adjustment / IntermediateField
re-classification issue was fixed by #21875 (Refactor
distributed-aggregate rewriter). Verified locally: 12/12 runs pass with
-Dtests.iters=3.

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
KhishorekumarBS pushed a commit to KhishorekumarBS/OpenSearch that referenced this pull request Jul 3, 2026
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
KhishorekumarBS pushed a commit to KhishorekumarBS/OpenSearch that referenced this pull request Jul 3, 2026
…#21901)

These four tests were muted by opensearch-project#21774 right after opensearch-project#21731 introduced
them. The underlying aggCall slot adjustment / IntermediateField
re-classification issue was fixed by opensearch-project#21875 (Refactor
distributed-aggregate rewriter). Verified locally: 12/12 runs pass with
-Dtests.iters=3.

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants