Fix DiskUsageTests NodeStats constructor call - #21770
Merged
Merged
Conversation
Signed-off-by: Craig Perkins <craig5008@gmail.com>
cwperks
marked this pull request as ready for review
May 20, 2026 23:59
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
reta
approved these changes
May 21, 2026
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21770 +/- ##
============================================
- Coverage 73.43% 73.40% -0.04%
+ Complexity 75103 75053 -50
============================================
Files 6016 6016
Lines 341072 341072
Branches 49091 49091
============================================
- Hits 250469 250348 -121
- Misses 70682 70785 +103
- Partials 19921 19939 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KhishorekumarBS
pushed a commit
to KhishorekumarBS/OpenSearch
that referenced
this pull request
Jul 3, 2026
Signed-off-by: Craig Perkins <craig5008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a compile failure in
DiskUsageTestscaused by the test helper using an outdatedNodeStatsconstructor argument list.Breaking change was #21637
Break can be seen in https://github.com/opensearch-project/OpenSearch/actions/runs/26195056157/job/77072446112
NodeStatsnow acceptsAnalyticsBackendNativeMemoryStatsas the final constructor argument. ThemakeNodeStatsWithResourceUsagehelper inDiskUsageTestswas missing that trailing argument, which caused CodeQL autobuild to fail during test compilation.This change adds the missing
nullargument so the helper matches the current constructor signature.Related Issues
Fixes
Check List
Testing
./gradlew :server:compileTestJava./gradlew :server:test --tests org.opensearch.cluster.DiskUsageTests./gradlew :server:spotlessJavaCheck