Using Github App token to trigger CI for version increment PRs by VachaShah · Pull Request #2157 · opensearch-project/OpenSearch

VachaShah · 2022-02-17T20:22:17Z

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Using Github App token to trigger CI on PRs created for version increment from the version.yml workflow. (opensearch-project/common-utils#111 (comment))

Issues Resolved

[List any issues this PR will resolve]

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>

opensearch-ci-bot · 2022-02-17T20:24:03Z

Can one of the admins verify this patch?

opensearch-ci-bot · 2022-02-17T21:08:02Z

✅ Gradle Check success e8e16eb
Log 2516

Reports 2516

owaiskazi19 · 2022-02-17T21:27:32Z

+        with:
+          app_id: ${{ secrets.APP_ID }}
+          private_key: ${{ secrets.APP_PRIVATE_KEY }}
+          installation_id: 22958780


Do we have any significance of this id?

Its the installation id of the opensearch-trigger-bot Github App.

Is it fine to expose it or should we add it in secrets?

Its fine. Its the same across all repos, we have been using it in backport and dependabot workflows.

Sounds good. Thanks for answering the questions.

owaiskazi19

LGTM!

opensearch-trigger-bot · 2022-02-17T22:13:18Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2157-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32a761df2ca117d24ed27a121195c4d8ef9ea1a0
# Push it to GitHub
git push --set-upstream origin backport/backport-2157-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2157-to-1.x.

opensearch-trigger-bot · 2022-02-17T22:13:31Z

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport/backport-2157-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32a761df2ca117d24ed27a121195c4d8ef9ea1a0
# Push it to GitHub
git push --set-upstream origin backport/backport-2157-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport/backport-2157-to-1.2.

VachaShah · 2022-02-17T22:21:57Z

Looks like 1.x and 1.2 don't have the version.yml file. @dblock Do we want to backport it?

dblock · 2022-02-18T00:32:35Z

Looks like 1.x and 1.2 don't have the version.yml file. @dblock Do we want to backport it?

I think we should backport it to 1.x, or that workflow won't run when we branch and then release 1.3.0. Would you please do that? Thank you.

VachaShah · 2022-02-18T00:39:32Z

Looks like 1.x and 1.2 don't have the version.yml file. @dblock Do we want to backport it?

I think we should backport it to 1.x, or that workflow won't run when we branch and then release 1.3.0. Would you please do that? Thank you.

Sure, I added a backport 1.x label to the original PR.

opensearch-trigger-bot · 2022-03-03T00:01:39Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2157-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32a761df2ca117d24ed27a121195c4d8ef9ea1a0
# Push it to GitHub
git push --set-upstream origin backport/backport-2157-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2157-to-1.x.

opensearch-trigger-bot · 2022-03-03T00:14:48Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2157-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32a761df2ca117d24ed27a121195c4d8ef9ea1a0
# Push it to GitHub
git push --set-upstream origin backport/backport-2157-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2157-to-1.x.

opensearch-trigger-bot · 2022-03-30T21:56:03Z

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2157-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32a761df2ca117d24ed27a121195c4d8ef9ea1a0
# Push it to GitHub
git push --set-upstream origin backport/backport-2157-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2157-to-1.x.

…earch-project#2157) Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Using Github App token to trigger CI for version increment PRs (#2157) Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing the indentation in version.yml (#2163) Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding signoff option for version workflow PR (#2572) Signed-off-by: Vacha Shah <vachshah@amazon.com>

Using Github App token to trigger CI for version increment PRs

e8e16eb

Signed-off-by: Vacha Shah <vachshah@amazon.com>

VachaShah requested a review from a team as a code owner February 17, 2022 20:22

owaiskazi19 reviewed Feb 17, 2022

View reviewed changes

VachaShah requested a review from dblock February 17, 2022 21:49

owaiskazi19 approved these changes Feb 17, 2022

View reviewed changes

dblock approved these changes Feb 17, 2022

View reviewed changes

dblock merged commit 32a761d into opensearch-project:main Feb 17, 2022

dblock added backport 1.x backport 1.2 labels Feb 17, 2022

VachaShah mentioned this pull request Feb 17, 2022

Fixing the indentation in version.yml #2163

Merged

1 task

VachaShah added backport 1.x and removed backport 1.x labels Mar 2, 2022

VachaShah added backport 1.x and removed backport 1.x backport 1.2 labels Mar 30, 2022

VachaShah added a commit to VachaShah/OpenSearch that referenced this pull request Mar 30, 2022

Using Github App token to trigger CI for version increment PRs (opens…

6c51b62

…earch-project#2157) Signed-off-by: Vacha Shah <vachshah@amazon.com>

VachaShah mentioned this pull request Mar 30, 2022

Backporting changes for version workflow #2676

Merged

1 task

VachaShah added a commit to VachaShah/OpenSearch that referenced this pull request Mar 30, 2022

Using Github App token to trigger CI for version increment PRs (opens…

702993d

…earch-project#2157) Signed-off-by: Vacha Shah <vachshah@amazon.com>

VachaShah mentioned this pull request Mar 30, 2022

Backporting changes for version workflow #2677

Merged

1 task

Conversation

VachaShah commented Feb 17, 2022

Description

Issues Resolved

Check List

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

opensearch-ci-bot commented Feb 17, 2022

Uh oh!

owaiskazi19 Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

VachaShah Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

VachaShah Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

owaiskazi19 left a comment

Choose a reason for hiding this comment

Uh oh!

opensearch-trigger-bot bot commented Feb 17, 2022

Uh oh!

opensearch-trigger-bot bot commented Feb 17, 2022

Uh oh!

VachaShah commented Feb 17, 2022

Uh oh!

dblock commented Feb 18, 2022

Uh oh!

VachaShah commented Feb 18, 2022

Uh oh!

opensearch-trigger-bot bot commented Mar 3, 2022

Uh oh!

opensearch-trigger-bot bot commented Mar 3, 2022

Uh oh!

opensearch-trigger-bot bot commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants