Skip to content

Update maven snapshots publishing to include sandbox jars - #21567

Merged
mch2 merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:maven-snapshots-sandboxtrue
May 8, 2026
Merged

Update maven snapshots publishing to include sandbox jars#21567
mch2 merged 1 commit into
opensearch-project:mainfrom
peterzhuamazon:maven-snapshots-sandboxtrue

Conversation

@peterzhuamazon

Copy link
Copy Markdown
Member

Description

Update maven snapshots publishing to include sandbox jars

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this May 8, 2026
@peterzhuamazon
peterzhuamazon requested review from a team, jed326 and peternied as code owners May 8, 2026 19:11
@peterzhuamazon peterzhuamazon added the enhancement Enhancement or improvement to existing feature or request label May 8, 2026
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 09e9fb3.

PathLineSeverityDescription
.github/workflows/publish-maven-snapshots.yml55lowAddition of `-Dsandbox.enabled=true` JVM system property to the Maven snapshot publish command. Unlike `-P` (Gradle project property), `-D` sets a JVM system property that could alter runtime behavior in ways not visible in this diff. The effect depends entirely on how `sandbox.enabled` is handled in the build or application code. Maintainers should verify this flag does not alter publish targets, artifact content, or enable hidden code paths during the publish pipeline.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 0 | Medium: 0 | Low: 1


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@peterzhuamazon peterzhuamazon moved this from Backlog to In review in OpenSearch Engineering Effectiveness May 8, 2026
@peterzhuamazon peterzhuamazon added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label May 8, 2026
@mch2
mch2 merged commit 87ebdb5 into opensearch-project:main May 8, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board May 8, 2026
@peterzhuamazon
peterzhuamazon deleted the maven-snapshots-sandboxtrue branch May 8, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants