Skip to content

Wire PPL string scalar functions with analytics-backend-datafusion #21543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mch2 merged 1 commit into from
May 8, 2026
Merged

Wire PPL string scalar functions with analytics-backend-datafusion #21543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...x/libs/analytics-framework/src/main/java/org/opensearch/analytics/spi/ScalarFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public enum ScalarFunction {
UPPER(Category.STRING, SqlKind.OTHER_FUNCTION),
LOWER(Category.STRING, SqlKind.OTHER_FUNCTION),
TRIM(Category.STRING, SqlKind.TRIM),
SUBSTR(Category.STRING, SqlKind.OTHER_FUNCTION),
SUBSTRING(Category.STRING, SqlKind.OTHER_FUNCTION),
/**
* String concatenation. Calcite's {@code SqlStdOperatorTable.CONCAT} is a
Expand All @@ -66,9 +67,23 @@ public enum ScalarFunction {
* rename surfaces as a compile error rather than as a silent string mismatch at runtime.
*/
CONCAT(Category.STRING, SqlKind.OTHER_FUNCTION, SqlStdOperatorTable.CONCAT),
CONCAT_WS(Category.STRING, SqlKind.OTHER_FUNCTION),
CHAR_LENGTH(Category.STRING, SqlKind.OTHER_FUNCTION),
REPLACE(Category.STRING, SqlKind.OTHER_FUNCTION),
REGEXP_REPLACE(Category.STRING, SqlKind.OTHER_FUNCTION),
ASCII(Category.STRING, SqlKind.OTHER_FUNCTION),
LEFT(Category.STRING, SqlKind.OTHER_FUNCTION),
LENGTH(Category.STRING, SqlKind.OTHER_FUNCTION),
LOCATE(Category.STRING, SqlKind.OTHER_FUNCTION),
POSITION(Category.STRING, SqlKind.POSITION),
LTRIM(Category.STRING, SqlKind.OTHER_FUNCTION),
RTRIM(Category.STRING, SqlKind.OTHER_FUNCTION),
REVERSE(Category.STRING, SqlKind.OTHER_FUNCTION),
RIGHT(Category.STRING, SqlKind.OTHER_FUNCTION),
TOSTRING(Category.STRING, SqlKind.OTHER_FUNCTION),
NUMBER_TO_STRING(Category.STRING, SqlKind.OTHER_FUNCTION), // Alias for TOSTRING
TONUMBER(Category.STRING, SqlKind.OTHER_FUNCTION),
STRCMP(Category.STRING, SqlKind.OTHER_FUNCTION),

// ── Math ─────────────────────────────────────────────────────────
PLUS(Category.MATH, SqlKind.PLUS),
Expand Down
1 change: 1 addition & 0 deletions sandbox/plugins/analytics-backend-datafusion/rust/src/session_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ pub async unsafe fn create_session_context(
.build();

let ctx = SessionContext::new_with_state(state);
crate::udf::register_all(&ctx);

// Register default ListingTable for parquet scans
let listing_options = ListingOptions::new(Arc::new(ParquetFormat::new()))
Expand Down
6 changes: 5 additions & 1 deletion sandbox/plugins/analytics-backend-datafusion/rust/src/udf/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,14 @@ pub(crate) fn coerce_args(
}

pub mod convert_tz;
pub mod tonumber;
pub mod tostring;

pub fn register_all(ctx: &SessionContext) {
convert_tz::register_all(ctx);
log::info!("OpenSearch UDF register_all: convert_tz registered");
tonumber::register_all(ctx);
tostring::register_all(ctx);
log::info!("OpenSearch UDF register_all: convert_tz, tonumber, tostring registered");
}

#[cfg(test)]
Expand Down
Loading
Loading