Fix BlockTransferManagerTests to extend OpenSearchTestCase instead of LuceneTestCase

[MayankHarsh03]

Description

BlockTransferManagerTests was extending LuceneTestCase directly, which causes sysout check failures in CI since the test uses loggers that print to console during execution. Changed the base class to OpenSearchTestCase which already includes @SuppressSysoutChecks and follows the project convention for all tests in the server/ module.

Related Issues

Related to #21355

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit a485fba)

Here are some key observations to aid the review process:

🧪 PR contains tests

🔒 No security concerns identified

✅ No TODO sections

🔀 No multiple PR themes

⚡ No major issues detected

[github-actions]

❌ Gradle check result for 5bcabc1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mgodwan]

Execution failed for task ':server:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/opensearch/storage/common/BlockTransferManagerTests.java
          @@ -12,7 +12,6 @@
           
           import·org.apache.lucene.store.FSDirectory;
           import·org.apache.lucene.store.IOContext;
          -import·org.opensearch.test.OpenSearchTestCase;
           import·org.opensearch.Version;
           import·org.opensearch.cluster.metadata.IndexMetadata;
           import·org.opensearch.common.UUIDs;
          @@ -23,6 +22,7 @@
           import·org.opensearch.index.store.remote.utils.TransferManager;
           import·org.opensearch.node.Node;
           import·org.opensearch.storage.indexinput.BlockFetchRequest;
          +import·org.opensearch.test.OpenSearchTestCase;
           import·org.opensearch.threadpool.ThreadPool;
           import·org.junit.After;
           import·org.junit.Assert;
  Run './gradlew spotlessApply' to fix all violations.

[github-actions]

Persistent review updated to latest commit 0d1982f

[github-actions]

Persistent review updated to latest commit 8e79bf9

[github-actions]

✅ Gradle check result for 8e79bf9: SUCCESS

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.47%. Comparing base (436e4a6) to head (a485fba).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #21363      +/-   ##
============================================
+ Coverage     73.34%   73.47%   +0.12%     
- Complexity    74223    74333     +110     
============================================
  Files          5958     5958              
  Lines        337309   337359      +50     
  Branches      48664    48687      +23     
============================================
+ Hits         247408   247870     +462     
+ Misses        70188    69754     -434     
- Partials      19713    19735      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Persistent review updated to latest commit a485fba

[github-actions]

✅ Gradle check result for a485fba: SUCCESS