Skip to content

Fix worker gone test failure in sandbox #21270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mch2 merged 3 commits into from
Apr 22, 2026
Merged

Fix worker gone test failure in sandbox #21270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb4089d
Fix worker gone test failure in sandbox
cwperks Apr 10, 2026
ff45209
Merge branch 'main' into worker-gone
cwperks Apr 17, 2026
64d145c
Fix flaky test
cwperks Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...nd-datafusion/src/test/java/org/opensearch/be/datafusion/DataFusionNativeBridgeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,13 @@
*/
public class DataFusionNativeBridgeTests extends OpenSearchTestCase {

// Note: initTokioRuntimeManager uses OnceLock and can only be initialized once per JVM.
// Do NOT call shutdownTokioRuntimeManager() here — it permanently kills the shared
// executor and other test classes (DatafusionSearchExecEngineTests, etc.) will fail
// with "Worker gone" if they run after this class.

public void testRuntimeLifecycle() {
// Init tokio runtime
// Init tokio runtime (no-op if already initialized by another test class)
NativeBridge.initTokioRuntimeManager(2);

// Create global runtime with small memory pool
Expand All @@ -35,9 +40,8 @@ public void testRuntimeLifecycle() {
);
assertTrue("Runtime pointer should be non-zero", runtimePtr != 0);

// Clean up
// Clean up the per-test runtime only
NativeBridge.closeGlobalRuntime(runtimePtr);
NativeBridge.shutdownTokioRuntimeManager();
}

public void testReaderLifecycle() throws Exception {
Expand All @@ -58,6 +62,5 @@ public void testReaderLifecycle() throws Exception {
readerHandle.close();

NativeBridge.closeGlobalRuntime(runtimePtr);
NativeBridge.shutdownTokioRuntimeManager();
}
}
2 changes: 0 additions & 2 deletions ...atafusion/src/test/java/org/opensearch/be/datafusion/DatafusionSearchExecEngineTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

package org.opensearch.be.datafusion;

import org.apache.lucene.tests.util.LuceneTestCase.AwaitsFix;
import org.opensearch.analytics.backend.EngineResultBatch;
import org.opensearch.analytics.backend.EngineResultStream;
import org.opensearch.be.datafusion.nativelib.NativeBridge;
Expand All @@ -26,7 +25,6 @@
* DatafusionReader → DatafusionContext → DatafusionSearchExecEngine → EngineResultStream → EngineResultBatch.
* Uses sqlToSubstrait to generate plan bytes, then exercises the real plugin classes.
*/
@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/21195")
public class DatafusionSearchExecEngineTests extends OpenSearchTestCase {

private ReaderHandle readerHandle;
Expand Down
Loading