Skip to content

Use pluggable DirectoryFactory in shard store validation (draft) - #21247

Open
krishna-ggk wants to merge 53 commits into
opensearch-project:mainfrom
krishna-ggk:pluggable-directory-store-validation
Open

Use pluggable DirectoryFactory in shard store validation (draft)#21247
krishna-ggk wants to merge 53 commits into
opensearch-project:mainfrom
krishna-ggk:pluggable-directory-store-validation

Merge branch 'main' into pluggable-directory-store-validation

85f08bf
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Apr 28, 2026 in 1s

DCO

There are 23 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~53 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin pluggable-directory-store-validation

Summary

Commit sha: 1f31a17, Author: A S K Kamal Nayan, Committer: Gopala Krishna A; Expected "A S K Kamal Nayan askkamalnayan9@gmail.com", but got "Kamal Nayan askkamal@amazon.com".
Commit sha: 3c960cd, Author: Andrew Ross, Committer: Gopala Krishna A; The sign-off is missing.
Commit sha: ac1ae2f, Author: Divya, Committer: Gopala Krishna A; Expected "Divya 117009486+divyaruhil@users.noreply.github.com", but got "Divya divyruhil999@gmail.com".
Commit sha: aa5677a, Author: expani1729, Committer: Gopala Krishna A; The sign-off is missing.
Commit sha: 931ca65, Author: Gaurav Bafna, Committer: Gopala Krishna A; Expected "Gaurav Bafna 85113518+gbbafna@users.noreply.github.com", but got "Gaurav Bafna gbbafna@amazon.com".
Commit sha: 417435b, Author: Himshikha Gupta, Committer: Gopala Krishna A; Expected "Himshikha Gupta gupta.himshikha@gmail.com", but got "Himshikha Gupta himshikh@amazon.com".
Commit sha: 44ba0f2, Author: Kavya Aggarwal, Committer: Gopala Krishna A; Expected "Kavya Aggarwal 154978013+GeekGlider@users.noreply.github.com", but got "Kavya Aggarwal kavyaagg@amazon.com".
Commit sha: 2105e1d, Author: Kavya Aggarwal, Committer: Gopala Krishna A; Expected "Kavya Aggarwal 154978013+GeekGlider@users.noreply.github.com", but got "kavyaagg kavyaagg@amazon.com".
Commit sha: c7f4e2b, Author: MayankHarsh03, Committer: Gopala Krishna A; Expected "MayankHarsh03 156461043+MayankHarsh03@users.noreply.github.com", but got "Mayank Harsh mayankmh@amazon.com".
Commit sha: 1b492b0, Author: MayankHarsh03, Committer: Gopala Krishna A; Expected "MayankHarsh03 156461043+MayankHarsh03@users.noreply.github.com", but got "Mayank Harsh mayankmh@amazon.com".
Commit sha: ccdda9c, Author: MayankHarsh03, Committer: Gopala Krishna A; Expected "MayankHarsh03 156461043+MayankHarsh03@users.noreply.github.com", but got "Mayank Harsh mayankmh@amazon.com".
Commit sha: b8303b5, Author: Mohit Godwani, Committer: Gopala Krishna A; Expected "Mohit Godwani 81609427+mgodwan@users.noreply.github.com", but got "Mohit Godwani mgodwan@amazon.com".
Commit sha: f9c803c, Author: Mohit Godwani, Committer: Gopala Krishna A; Expected "Mohit Godwani 81609427+mgodwan@users.noreply.github.com", but got "Mohit Godwani mgodwan@amazon.com".
Commit sha: 199c0f7, Author: Nishchay Malhotra, Committer: Gopala Krishna A; Expected "Nishchay Malhotra 114057571+nishchay21@users.noreply.github.com", but got "Nishchay Malhotra nishchay.malhotra@gmail.com".
Commit sha: c206fb2, Author: rayshrey, Committer: Gopala Krishna A; Can not find "rayshrey 121871912+rayshrey@users.noreply.github.com", in ["rayshrey rayshrey@amazon.com", "Bukhtawar Khan bukhtawa@amazon.com", "rayshrey rayshrey@amazon.com", "rayshrey rayshrey@amazon.com", "rayshrey rayshrey@amazon.com", "rayshrey rayshrey@amazon.com", "rayshrey rayshrey@amazon.com", "Bukhtawar Khan bukhtawa@amazon.com"].
Commit sha: 53ec49d, Author: rayshrey, Committer: Gopala Krishna A; Can not find "rayshrey 121871912+rayshrey@users.noreply.github.com", in ["rayshrey rayshrey@amazon.com", "rayshrey rayshrey@amazon.com", "rayshrey rayshrey@amazon.com"].
Commit sha: 032f469, Author: Sagar Darji, Committer: Gopala Krishna A; Can not find "Sagar Darji 42430138+darjisagar7@users.noreply.github.com", in ["Sagar Darji darsaga@amazon.com", "Sagar Darji darsaga@amazon.com", "Bukhtawar Khan bukhtawa@amazon.com", "Bukhtawar Khan bukhtawa@amazon.com", "Sagar Darji darsaga@amazon.com", "Sagar Darji darsaga@amazon.com", "Sagar Darji darsaga@amazon.com", "Sagar Darji darsaga@amazon.com", "Bukhtawar Khan bukhtawa@amazon.com"].
Commit sha: f97fadf, Author: Sagar Upadhyaya, Committer: Gopala Krishna A; Expected "Sagar Upadhyaya 99425694+sgup432@users.noreply.github.com", but got "Sagar Upadhyaya sagar.upadhyaya.121@gmail.com".
Commit sha: e23b6c8, Author: Sai Asish Y, Committer: Gopala Krishna A; Expected "Sai Asish Y say.apm35@gmail.com", but got "SAY-5 SAY-5@users.noreply.github.com".
Commit sha: 823a9fc, Author: Sai Asish Y, Committer: Gopala Krishna A; The sign-off is missing.
Commit sha: e40ca68, Author: Xi Lu, Committer: Gopala Krishna A; Can not find "Xi Lu fridalu66@gmail.com", in ["Yiyu Pan yypan14@gmail.com", "Patrick Zhai pzhai@uber.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "Yiyu Pan yypan14@gmail.com", "Patrick Zhai pzhai@uber.com", "xil fridalu66@gmail.com"].
Commit sha: a4c7d34, Author: Xi Lu, Committer: Gopala Krishna A; Can not find "Xi Lu fridalu66@gmail.com", in ["xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com", "xil fridalu66@gmail.com"].
Commit sha: 479c42d, Author: Yuan, Committer: Gopala Krishna A; Expected "Yuan yuan13215@163.com", but got "yuan13215 yuan13215@163.com".

View more details on DCO