Skip to content

[2.19] update netty to 4.1.132.Final - #21224

Merged
reta merged 1 commit into
opensearch-project:2.19from
rursprung:update-netty-on-2.19
Apr 14, 2026
Merged

[2.19] update netty to 4.1.132.Final#21224
reta merged 1 commit into
opensearch-project:2.19from
rursprung:update-netty-on-2.19

Conversation

@rursprung

Copy link
Copy Markdown
Contributor

Description

this resolves CVE-2026-33870, amongst others,
see the full changelog: https://netty.io/news/2026/03/24/4-1-132-Final.html

note: this only applies to 2.19.x, for 3.x we're already on netty 4.2.x.

Related Issues

n/a

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rursprung
rursprung requested review from a team and peternied as code owners April 14, 2026 12:44
@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit df37123.

PathLineSeverityDescription
gradle/libs.versions.toml37highDependency version change: netty updated from 4.1.131.Final to 4.1.132.Final. Per mandatory policy, all dependency version changes must be flagged. Maintainers should verify the new SHA1 hashes against official Netty release artifacts from the authoritative source.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 1 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

this resolves CVE-2026-33870, amongst others, see the full changelog:
https://netty.io/news/2026/03/24/4-1-132-Final.html

note: this only applies to 2.19.x, for 3.x we're already on netty 4.2.x.

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
@rursprung
rursprung force-pushed the update-netty-on-2.19 branch from e3e0659 to df37123 Compare April 14, 2026 12:46
@reta reta added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Apr 14, 2026
@reta reta added the dependencies Pull requests that update a dependency file label Apr 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

SHA1 Verification

The SHA1 checksums for the new netty 4.1.132.Final JARs should be verified against the official Netty release artifacts to ensure integrity. SHA1 hashes are provided as single-line files and should be cross-checked with the official Netty release page or Maven Central.

netty             = "4.1.132.Final"

@github-actions

Copy link
Copy Markdown
Contributor

❌ Gradle check result for df37123: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rursprung

Copy link
Copy Markdown
Contributor Author

the test failure seems to be due to an infrastructure issue (jenkins job didn't trigger?)

@github-actions

Copy link
Copy Markdown
Contributor

✅ Gradle check result for df37123: SUCCESS

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.93%. Comparing base (aff3489) to head (df37123).
⚠️ Report is 1 commits behind head on 2.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               2.19   #21224   +/-   ##
=========================================
  Coverage     71.92%   71.93%           
+ Complexity    66009    65961   -48     
=========================================
  Files          5342     5342           
  Lines        307392   307392           
  Branches      44862    44862           
=========================================
+ Hits         221105   221124   +19     
+ Misses        67823    67777   -46     
- Partials      18464    18491   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reta
reta merged commit 469dc93 into opensearch-project:2.19 Apr 14, 2026
60 of 64 checks passed
@rursprung
rursprung deleted the update-netty-on-2.19 branch April 16, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants