Add dedicated CI check for sandbox running on Github - #21175
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 9ae4fbb.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
PR Reviewer Guide 🔍(Review updated until commit 73de7c0)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 73de7c0 Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit a80a3a5
Suggestions up to commit 9ae4fbb
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Persistent review updated to latest commit a80a3a5 |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Persistent review updated to latest commit 73de7c0 |
…ect#21175) * Add dedicated CI check for sandbox running on Github Signed-off-by: Craig Perkins <cwperx@amazon.com> * part1 and part2 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix syntax Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Aparajita Pandey <aparajita31pandey@gmail.com>
…ect#21175) * Add dedicated CI check for sandbox running on Github Signed-off-by: Craig Perkins <cwperx@amazon.com> * part1 and part2 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix syntax Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…ect#21175) * Add dedicated CI check for sandbox running on Github Signed-off-by: Craig Perkins <cwperx@amazon.com> * part1 and part2 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix syntax Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
This PR creates a separate CI check for sandbox plugins and uses Github as a runner instead of the Jenkins infrastructure. The workflow installs pre-requisites and 1) Uses JDK 25 - needed for virtual threads and 2) installs rust and the protobuf compiler.
Note: This will duplicate effort currently in jenkins. However, if #21125 is merged then sandbox will no longer run on jenkins by default unless
-Dsandbox.enabled=trueis passed.Related Issues
Related to discussion on #21174
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.