Move bundled JDK to JDK-26 - #21170
Draft
reta wants to merge 1 commit into
Draft
Conversation
reta
added
the
Build
Contributor
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit ad3c511.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
reta
added
the
skip-diff-analyzer
Contributor
PR Reviewer Guide 🔍(Review updated until commit 727a03f)Here are some key observations to aid the review process:
|
Contributor
|
❌ Gradle check result for ad3c511: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Persistent review updated to latest commit d83e481 |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21170 +/- ##
============================================
- Coverage 71.61% 71.58% -0.03%
+ Complexity 77336 77285 -51
============================================
Files 6170 6170
Lines 359671 359685 +14
Branches 52450 52450
============================================
- Hits 257584 257490 -94
- Misses 81696 81731 +35
- Partials 20391 20464 +73 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
Contributor
Author
|
{"run-benchmark-test": "id_3"} |
Contributor
|
Persistent review updated to latest commit dc7fd62 |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/6666/ . Final results will be published once the job is completed. |
Contributor
|
❌ Gradle check result for dc7fd62: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for dc7fd62: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/6666/
|
Contributor
|
❌ Gradle check result for dc7fd62: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Bukhtawar
reviewed
Apr 9, 2026
Bukhtawar
left a comment
Bukhtawar
left a comment
Contributor
There was a problem hiding this comment.
JDK-25 is an LTS release, do we really want to go to JDK-26 short-term?
Contributor
Author
Not necessarily, we use to always run on latest JDK (non-LTS) if there are benefits (fe coming from Lucene or impactful fixes). The selling points why we may want to go with JDK-26 are in description, thanks @Bukhtawar |
Contributor
|
Persistent review updated to latest commit 298057a |
Contributor
|
❌ Gradle check result for 298057a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❕ Gradle check result for 298057a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Contributor
|
Persistent review updated to latest commit 17195cf |
Contributor
Contributor
|
Persistent review updated to latest commit e525aa0 |
Contributor
|
❌ Gradle check result for e525aa0: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Persistent review updated to latest commit 672af66 |
Contributor
|
❌ Gradle check result for 672af66: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Contributor
|
Persistent review updated to latest commit f31c8f9 |
Contributor
|
❌ Gradle check result for f31c8f9: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for f31c8f9: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Contributor
|
Persistent review updated to latest commit 190b888 |
Contributor
|
❌ Gradle check result for 190b888: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Persistent review updated to latest commit 55d5af5 |
Contributor
|
❌ Gradle check result for 55d5af5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Persistent review updated to latest commit 2fb7733 |
Contributor
|
❌ Gradle check result for 2fb7733: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Contributor
|
Persistent review updated to latest commit c377416 |
Contributor
|
❌ Gradle check result for c377416: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Signed-off-by: Andriy Redko <drreta@gmail.com>
Contributor
|
Persistent review updated to latest commit 727a03f |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move bundled JDK to JDK-26
Related Issues
Most notable improvements:
And, not yet relevant for us but still - JDK-8369238: Allow virtual thread preemption on some common class initialization paths
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.