Skip to content

Revert "Split gradle check into parallel check and bwc jobs (#21106)" - #21112

Merged
cwperks merged 1 commit into
opensearch-project:mainfrom
andrross:revert-split
Apr 3, 2026
Merged

Revert "Split gradle check into parallel check and bwc jobs (#21106)"#21112
cwperks merged 1 commit into
opensearch-project:mainfrom
andrross:revert-split

Conversation

@andrross

@andrross andrross commented Apr 3, 2026

Copy link
Copy Markdown
Member

This reverts commit a3f2f3f.

This isn't working, but I don't know why. Need to figure out a way to test it, otherwise we'll block PRs.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ch-project#21106)"

This reverts commit a3f2f3f.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross
andrross requested review from a team, jed326 and peternied as code owners April 3, 2026 22:09
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Missing BWC Coverage

By reverting the split, the bwcTestSnapshots gradle check command is no longer being run. The workflow now only triggers the default gradle check without explicitly passing a command, which may omit BWC (backward compatibility) testing entirely depending on what the script defaults to.

bash opensearch-build/scripts/gradle/gradle-check.sh -t ${{ secrets.JENKINS_GRADLE_CHECK_GENERIC_WEBHOOK_TOKEN }} -u ${{ secrets.JENKINS_GITHUB_USER}} -p ${{ secrets.JENKINS_GITHUB_USER_TOKEN}} | tee -a gradle-check.log
Single Job Bottleneck

Reverting to a single non-matrix job means check and bwc tests run sequentially (or not at all), increasing total CI time and potentially blocking PRs longer than the parallel approach would have.

needs: [check-files, Code-Diff-Analyzer]
if: github.repository == 'opensearch-project/OpenSearch' && needs.check-files.outputs.RUN_GRADLE_CHECK == 'true'
permissions:
  contents: read # to fetch code (actions/checkout)
  pull-requests: write # to create or update comment (peter-evans/create-or-update-comment)
  issues: write # To create an issue if check fails on push.
runs-on: ubuntu-latest
timeout-minutes: 130

@cwperks

cwperks commented Apr 3, 2026

Copy link
Copy Markdown
Member

Overriding and merging to unblock ci from previous change.

@cwperks
cwperks merged commit 1b7fd23 into opensearch-project:main Apr 3, 2026
21 of 23 checks passed
@andrross
andrross deleted the revert-split branch April 3, 2026 22:10
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

❌ Build result for bwc (897ede4): FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

❌ Build result for check (897ede4): FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants