Skip to content

[Backport 3.5] Fix the regression of terms agg optimization - #20718

Merged
jainankitk merged 2 commits into
3.5from
backport/backport-20623-to-3.5
Feb 24, 2026
Merged

[Backport 3.5] Fix the regression of terms agg optimization#20718
jainankitk merged 2 commits into
3.5from
backport/backport-20623-to-3.5

Conversation

@opensearch-trigger-bot

Copy link
Copy Markdown
Contributor

Backport 8c244c0 from #20623.

* Fix the regression of terms agg optimization

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* Change log

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

* add code coverage

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

---------

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 8c244c0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Remove several entries related to test fixes, criteria updates, and codec improvements from the CHANGELOG.

Signed-off-by: Ankit Jain <jainankitk@apache.org>
@github-actions

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 5c34bec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions

Copy link
Copy Markdown
Contributor

❌ Gradle check result for 5c34bec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk

Copy link
Copy Markdown
Contributor

Unrelated failures, retrying gradle check:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/) (10 failures / +9)

    [org.opensearch.action.admin.cluster.filecache.PruneFileCacheIT.testPruneCacheWithRealData](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.action.admin.cluster.filecache/PruneFileCacheIT/testPruneCacheWithRealData/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testWithMultipleIndexCreationAndVerifySettingRegisteredOnce](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testWithMultipleIndexCreationAndVerifySettingRegisteredOnce/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testClusterSettingsUpdateResponse](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testClusterSettingsUpdateResponse/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testThreadPoolSettings](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testThreadPoolSettings/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testMissingUnits](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testMissingUnits/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testClusterNonExistingSettingsUpdate](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testClusterNonExistingSettingsUpdate/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testLoggerLevelUpdate](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testLoggerLevelUpdate/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testCanUpdateTracerSettings](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testCanUpdateTracerSettings/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testDeleteIsAppliedFirst](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testDeleteIsAppliedFirst/)
    [org.opensearch.cluster.settings.ClusterSettingsIT.testUpdateSettings](https://build.ci.opensearch.org/job/gradle-check/71715/testReport/junit/org.opensearch.cluster.settings/ClusterSettingsIT/testUpdateSettings/)

@github-actions

Copy link
Copy Markdown
Contributor

✅ Gradle check result for 5c34bec: SUCCESS

@jainankitk
jainankitk merged commit 6aed8ff into 3.5 Feb 24, 2026
37 of 41 checks passed
@github-actions
github-actions Bot deleted the backport/backport-20623-to-3.5 branch February 24, 2026 02:50
@codecov

codecov Bot commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.32%. Comparing base (367e368) to head (5c34bec).
⚠️ Report is 1 commits behind head on 3.5.

Files with missing lines Patch % Lines
...ket/terms/GlobalOrdinalsStringTermsAggregator.java 66.66% 0 Missing and 1 partial ⚠️
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.5   #20718      +/-   ##
============================================
+ Coverage     73.18%   73.32%   +0.14%     
- Complexity    71881    71941      +60     
============================================
  Files          5782     5782              
  Lines        329070   329080      +10     
  Branches      47448    47449       +1     
============================================
+ Hits         240823   241299     +476     
+ Misses        68953    68415     -538     
- Partials      19294    19366      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant