Conversation
Signed-off-by: opensearch-ci <opensearch-infra@amazon.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
Signed-off-by: opensearch-ci <opensearch-infra@amazon.com>
Signed-off-by: opensearch-ci <opensearch-infra@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
|
@rishabh6788 I've added another file here which are the release notes built from the CHANGELOG so that we can easily compare the two. |
|
@rishabh6788 In general I'd say the generated release notes look mostly reasonable, except for the "unknown" section. |
|
If we are changing the format of release notes, I think we should change the format of changelog as well? For this release, we can probably keep the same format as existing changelog? |
* remove documentation section * moved entries of unknown section to relevant sections Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
|
There are 21 PRs that are in the CHANGELOG format but not in the generated format: #18056 At least a few of these are reasonable to exclude from release notes (i.e. test fixes). However many are bug fixes or important dependency updates. @rishabh6788 How did the release notes tool decide to exclude certain commits? |
@andrross That's why I was keen on keeping the format same as changelog for this release and then go to a new format from next release. |
Signed-off-by: Andrew Ross <andrross@amazon.com>
|
@sandeshkr419 This should be good to merge now. I've used the changelog-based contents for the release notes. |
Signed-off-by: opensearch-ci <opensearch-infra@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> Co-authored-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Sandesh Kumar <sandeshkr419@gmail.com> (cherry picked from commit 9d1f4fc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 9d1f4fc) Signed-off-by: opensearch-ci <opensearch-infra@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Sandesh Kumar <sandeshkr419@gmail.com>
Add release notes for 3.5.0