Increment version to 3.5.0#20276
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
WalkthroughBumps OpenSearch from 3.4.0 to 3.5.0 in build metadata and code, adds "3.4.0" to the BWC list, introduces V_3_5_0 and sets CURRENT to it in Version.java, makes Tar tasks depend on their base stage tasks, and adds a Linux cleanup step to the assemble CI workflow. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
🔇 Additional comments (1)
Comment |
|
❌ Gradle check result for 21bab3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 21bab3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Potentially related to #19856? We solved a somewhat similar issue like #19634, but they are not exactly the same. |
|
TIL about the In order to test out a fix, I needed to make a change on my local 3.4 branch and then run: |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
❌ Gradle check result for 8de0751: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
❌ Gradle check result for 55303a9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/assemble.yml (1)
19-24: LGTM! Disk cleanup step is a sensible addition.The cleanup step follows a well-established pattern for freeing disk space on GitHub Actions runners, which may help address the integTest failures mentioned in the PR comments. Given that this PR adds BWC version 3.4.0 to the testing matrix, additional disk space may be needed for building and testing backward compatibility artifacts.
Optional: Simplify the conditional syntax
The
${{ }}wrapper is optional inifconditions and can be omitted for cleaner syntax:- if: ${{ runner.os == 'Linux' }} + if: runner.os == 'Linux'Please verify whether this cleanup step resolves or mitigates the integTest failure reported by gaiksaya regarding the missing BWC build artifacts.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/assemble.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: gradle-check
- GitHub Check: precommit (25, macos-15-intel)
- GitHub Check: precommit (21, windows-2025, true)
- GitHub Check: precommit (25, windows-latest)
- GitHub Check: precommit (21, ubuntu-latest)
- GitHub Check: precommit (21, windows-latest)
- GitHub Check: precommit (25, ubuntu-24.04-arm)
- GitHub Check: precommit (21, macos-15)
- GitHub Check: precommit (21, ubuntu-24.04-arm)
- GitHub Check: precommit (21, macos-15-intel)
- GitHub Check: precommit (25, macos-15)
- GitHub Check: precommit (25, ubuntu-latest)
- GitHub Check: detect-breaking-change
- GitHub Check: Analyze (java)
|
❌ Gradle check result for ff9d80d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This should be unblocked now that #20281 is merged. |
|
❌ Gradle check result for ff9d80d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
It checked out the old sha, not sure why... |
|
❌ Gradle check result for 14e35d1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 14e35d1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 14e35d1: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20276 +/- ##
============================================
+ Coverage 73.20% 73.30% +0.10%
- Complexity 71745 71796 +51
============================================
Files 5795 5795
Lines 328304 328299 -5
Branches 47283 47279 -4
============================================
+ Hits 240334 240666 +332
+ Misses 68663 68328 -335
+ Partials 19307 19305 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Description
Increment version to 3.5.0 following 3.4.0 release
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.