Fix ClassCastException in FlightClientChannel for large requests#20010
Merged
jainankitk merged 1 commit intoopensearch-project:mainfrom Nov 15, 2025
Merged
Conversation
rishabhmaurya
force-pushed
the
fix-flight-classcast
branch
from
9c7e915 to
0190068
Compare
Replace unsafe BytesArray cast with BytesReference.toBytes() Signed-off-by: Rishabh Maurya <[email protected]>
rishabhmaurya
force-pushed
the
fix-flight-classcast
branch
from
0190068 to
1b49220
Compare
jiapingzeng
approved these changes
Nov 15, 2025
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20010 +/- ##
============================================
- Coverage 73.30% 73.24% -0.07%
- Complexity 71635 71642 +7
============================================
Files 5789 5789
Lines 327204 327203 -1
Branches 47296 47296
============================================
- Hits 239870 239663 -207
- Misses 68113 68351 +238
+ Partials 19221 19189 -32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
approved these changes
Nov 15, 2025
github-project-automation
bot
moved this from Todo
to In Progress
in Performance Roadmap
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2025
) Replace unsafe BytesArray cast with BytesReference.toBytes() Signed-off-by: Rishabh Maurya <[email protected]> (cherry picked from commit cdc40c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Dec 5, 2025
…nsearch-project#20010) Replace unsafe BytesArray cast with BytesReference.toBytes() Signed-off-by: Rishabh Maurya <[email protected]>
liuguoqingfz
pushed a commit
to liuguoqingfz/OpenSearch
that referenced
this pull request
Dec 15, 2025
…nsearch-project#20010) Replace unsafe BytesArray cast with BytesReference.toBytes() Signed-off-by: Rishabh Maurya <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unsafe BytesArray cast with BytesReference.toBytes()
Description
serializeToTicket()castsBytesReferenceto BytesArray, failing for requests >16KB which usePagedBytesReference-Fix: Replace unsafe BytesArray cast with BytesReference.toBytes()
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.