-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Support range semver for dependencies in plugin-descriptor.properties #19939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support range semver for dependencies in plugin-descriptor.properties #19939
Conversation
Signed-off-by: Aparajita Pandey <[email protected]>
|
❌ Gradle check result for 1a8aeb4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Aparajita Pandey <[email protected]>
|
❌ Gradle check result for fe6f629: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Aparajita Pandey <[email protected]>
Signed-off-by: Aparajita Pandey <[email protected]>
Signed-off-by: Aparajita Pandey <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19939 +/- ##
============================================
- Coverage 73.27% 73.20% -0.08%
+ Complexity 71563 71553 -10
============================================
Files 5785 5785
Lines 326822 326826 +4
Branches 47294 47295 +1
============================================
- Hits 239484 239255 -229
- Misses 68111 68350 +239
+ Partials 19227 19221 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cwperks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix @aparajita31pandey !
…opensearch-project#19939) * DependenciesRangeSemver Signed-off-by: Aparajita Pandey <[email protected]> * spotlessApply Signed-off-by: Aparajita Pandey <[email protected]> * testCase Signed-off-by: Aparajita Pandey <[email protected]> * ChangeLog Signed-off-by: Aparajita Pandey <[email protected]> * correct changeLog Signed-off-by: Aparajita Pandey <[email protected]> --------- Signed-off-by: Aparajita Pandey <[email protected]>
…opensearch-project#19939) * DependenciesRangeSemver Signed-off-by: Aparajita Pandey <[email protected]> * spotlessApply Signed-off-by: Aparajita Pandey <[email protected]> * testCase Signed-off-by: Aparajita Pandey <[email protected]> * ChangeLog Signed-off-by: Aparajita Pandey <[email protected]> * correct changeLog Signed-off-by: Aparajita Pandey <[email protected]> --------- Signed-off-by: Aparajita Pandey <[email protected]>
Description
This change #18557 added support for range version support in semver. This range semver only works for
opensearch.versionfield inplugin-descriptor.propertiesand doesn't work fordependenciesin plugin-descriptor.properties. This PR adds similar support fordependenciestoo.Using
dependencies={ opensearch: "[2.0.0, 3.9.0)" }, gives below errorRelated Issues
Builds on #1707
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.