Skip to content

Support new and old signature for ActionPlugin.getRestHandlerWrapper#19901

Merged
msfroh merged 1 commit intoopensearch-project:mainfrom
cwperks:double-ext-point
Nov 5, 2025
Merged

Support new and old signature for ActionPlugin.getRestHandlerWrapper#19901
msfroh merged 1 commit intoopensearch-project:mainfrom
cwperks:double-ext-point

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Nov 5, 2025

Description

This re-introduces the old signature for ActionPlugin.getRestHandlerWrapper to ensure that plugins can define either one or the other.

Related Issues

Resolves #19875 (comment)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner November 5, 2025 19:17
@cwperks
Copy link
Member Author

cwperks commented Nov 5, 2025

@msfroh @aparajita31pandey this should allow you to use dependencies={ opensearch: "^3.1.0" } for the whole 3.x line.

Also FYI, that syntax also supports defining ranges like this: dependencies={ opensearch: "[3.0.0, 3.4.0)" }

If a plugin ever relies on extension points marked @opensearch.experimental, then expect changes from one minor version to the next until the experimental label is removed. In this case, ActionPlugin is not experimental so adding the previous extension point back in for bwc.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

✅ Gradle check result for 4cc3133: SUCCESS

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (4f519f9) to head (4cc3133).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19901      +/-   ##
============================================
+ Coverage     73.23%   73.28%   +0.05%     
- Complexity    71393    71404      +11     
============================================
  Files          5770     5770              
  Lines        325751   325752       +1     
  Branches      47177    47177              
============================================
+ Hits         238549   238721     +172     
+ Misses        68080    67846     -234     
- Partials      19122    19185      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwperks!

@msfroh msfroh merged commit ee324ee into opensearch-project:main Nov 5, 2025
37 of 38 checks passed
liuguoqingfz pushed a commit to liuguoqingfz/OpenSearch that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants