-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[Pull-based Ingestion] Add time based periodic flush support #19878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Add time based periodic flush support #19878
Conversation
58c8a02 to
458ed3d
Compare
458ed3d to
6a36a46
Compare
|
❌ Gradle check result for 6a36a46: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6a36a46: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6a36a46 to
7b55d32
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19878 +/- ##
============================================
- Coverage 73.21% 73.19% -0.03%
+ Complexity 71254 71248 -6
============================================
Files 5766 5766
Lines 325470 325514 +44
Branches 47084 47094 +10
============================================
- Hits 238296 238257 -39
- Misses 68043 68157 +114
+ Partials 19131 19100 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
42b69f6 to
9abade3
Compare
|
❌ Gradle check result for 9abade3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Bharadwaj <[email protected]>
|
❕ Gradle check result for b5073cc: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…rch-project#19878) --------- Signed-off-by: Varun Bharadwaj <[email protected]>
Description
Add a time based periodic flush task similar to the periodic refresh task at the shard level. This will default to 30 minutes for pull-based ingestion index. For regular indices, this will be disabled by default.
This will help ensure the batchStartPointer is persisted in the commit periodically, and prevent a large lag build up on replicas when promoted. It also ensures the batchStartPointer is not stale and older than the streaming source retention period given that there are incoming events.
Related Issues
Resolves #19860
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.