Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Oct 28, 2025

Description

Modules in this PR include:

  • crypto-kms plugin
  • repository-s3 plugin
  • repository-azure-classic plugin
  • repository-gcs plugin

Related Issues

Related to #18339

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner October 28, 2025 20:48
Signed-off-by: Craig Perkins <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for daa1491: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <[email protected]>
@github-actions
Copy link
Contributor

✅ Gradle check result for 003ec6e: SUCCESS

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 69.36937% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.19%. Comparing base (2f930dc) to head (f0c3d13).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...ch/repositories/gcs/GoogleCloudStorageService.java 46.15% 6 Missing and 1 partial ⚠️
...org/opensearch/repositories/s3/S3AsyncService.java 64.70% 5 Missing and 1 partial ⚠️
...java/org/opensearch/repositories/s3/S3Service.java 66.66% 5 Missing and 1 partial ⚠️
.../opensearch/repositories/azure/AzureBlobStore.java 28.57% 5 Missing ⚠️
.../repositories/gcs/GoogleCloudStorageBlobStore.java 44.44% 5 Missing ⚠️
...rg/opensearch/crypto/kms/KmsMasterKeyProvider.java 0.00% 2 Missing ⚠️
...ensearch/crypto/kms/CredentialProviderFactory.java 0.00% 1 Missing ⚠️
...ain/java/org/opensearch/crypto/kms/KmsService.java 75.00% 1 Missing ⚠️
...ories/gcs/GoogleApplicationDefaultCredentials.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19803      +/-   ##
============================================
- Coverage     73.24%   73.19%   -0.05%     
+ Complexity    71519    71500      -19     
============================================
  Files          5789     5785       -4     
  Lines        327121   327058      -63     
  Branches      47117    47116       -1     
============================================
- Hits         239591   239405     -186     
- Misses        68269    68403     +134     
+ Partials      19261    19250      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

✅ Gradle check result for ab90b6c: SUCCESS

@github-actions
Copy link
Contributor

✅ Gradle check result for a76f0be: SUCCESS

@cwperks
Copy link
Member Author

cwperks commented Nov 13, 2025

@sandeshkr419 I updated the AccessController interface to add a non-void method that throws a non-generic exception. That will clean this up a bit.

@cwperks
Copy link
Member Author

cwperks commented Nov 18, 2025

@sandeshkr419 I fixed the conflicts. Can you re-review when you have some time?

@github-actions
Copy link
Contributor

❌ Gradle check result for 283aba2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for f0c3d13: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for f0c3d13: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for f0c3d13: SUCCESS

@cwperks cwperks merged commit 3462571 into opensearch-project:main Nov 26, 2025
34 of 39 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Nov 28, 2025
…AccessController in sub projects with SocketAccess class (opensearch-project#19803)

* Replace AccessController in sub projects with SocketAccess class

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Add import

Signed-off-by: Craig Perkins <[email protected]>

* Address review comments

Signed-off-by: Craig Perkins <[email protected]>

* Address comments

Signed-off-by: Craig Perkins <[email protected]>

* Wrap exception

Signed-off-by: Craig Perkins <[email protected]>

* Wrap instead

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Dec 5, 2025
…AccessController in sub projects with SocketAccess class (opensearch-project#19803)

* Replace AccessController in sub projects with SocketAccess class

Signed-off-by: Craig Perkins <[email protected]>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <[email protected]>

* Add import

Signed-off-by: Craig Perkins <[email protected]>

* Address review comments

Signed-off-by: Craig Perkins <[email protected]>

* Address comments

Signed-off-by: Craig Perkins <[email protected]>

* Wrap exception

Signed-off-by: Craig Perkins <[email protected]>

* Wrap instead

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants