-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in sub projects with SocketAccess class #19803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace java.security.AccessController with org.opensearch.secure_sm.AccessController in sub projects with SocketAccess class #19803
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for daa1491: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19803 +/- ##
============================================
- Coverage 73.24% 73.19% -0.05%
+ Complexity 71519 71500 -19
============================================
Files 5789 5785 -4
Lines 327121 327058 -63
Branches 47117 47116 -1
============================================
- Hits 239591 239405 -186
- Misses 68269 68403 +134
+ Partials 19261 19250 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...epository-gcs/src/main/java/org/opensearch/repositories/gcs/GoogleCloudStorageBlobStore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
…nSearch into remove-socket-access
|
@sandeshkr419 I updated the AccessController interface to add a non-void method that throws a non-generic exception. That will clean this up a bit. |
Signed-off-by: Craig Perkins <[email protected]>
|
@sandeshkr419 I fixed the conflicts. Can you re-review when you have some time? |
|
❌ Gradle check result for 283aba2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…nSearch into remove-socket-access
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for f0c3d13: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f0c3d13: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…AccessController in sub projects with SocketAccess class (opensearch-project#19803) * Replace AccessController in sub projects with SocketAccess class Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Add import Signed-off-by: Craig Perkins <[email protected]> * Address review comments Signed-off-by: Craig Perkins <[email protected]> * Address comments Signed-off-by: Craig Perkins <[email protected]> * Wrap exception Signed-off-by: Craig Perkins <[email protected]> * Wrap instead Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…AccessController in sub projects with SocketAccess class (opensearch-project#19803) * Replace AccessController in sub projects with SocketAccess class Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Add import Signed-off-by: Craig Perkins <[email protected]> * Address review comments Signed-off-by: Craig Perkins <[email protected]> * Address comments Signed-off-by: Craig Perkins <[email protected]> * Wrap exception Signed-off-by: Craig Perkins <[email protected]> * Wrap instead Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Description
Modules in this PR include:
Related Issues
Related to #18339
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.