Add S3Repository.LEGACY_MD5_CHECKSUM_CALCULATION to list of repository-s3 settings

[cwperks]

Description

This is a small PR to make sure this setting can be used in opensearch.yml and not just on repo creation.

This was missed in #19220

Related Issues

See discussion around here: #18240 (comment)

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for fc4970e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[owaiskazi19]

@cwperks we can make this to 3.3.2

[cwperks]

@peterzhuamazon Can we get this to 3.3.2?

[github-actions]

❌ Gradle check result for 0786cff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 0786cff: SUCCESS

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.14%. Comparing base (753c135) to head (0786cff).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19788      +/-   ##
============================================
+ Coverage     73.10%   73.14%   +0.03%     
- Complexity    70959    70976      +17     
============================================
  Files          5737     5737              
  Lines        324766   324775       +9     
  Branches      46981    46982       +1     
============================================
+ Hits         237425   237558     +133     
+ Misses        68226    68108     -118     
+ Partials      19115    19109       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gbbafna]

Hi @cwperks , we are seeing a regression due to aws sdk version update . Details are in aws/aws-sdk-java-v2#6556 .

What would be the impact of reverting that ?

[cwperks]

@gbbafna I needed to upgrade to a later version of the SDK that had LegacyMd5Plugin.

[cwperks]

@gbbafna It was introduced in 2.31.32, can we try downgrading to that version?

Ref: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/s3-checksums.html?utm_source=chatgpt.com

[gbbafna]

Sure , I will try that and update this thread

[gbbafna]

It was introduced in 2.31.32, can we try downgrading to that version?

With this version , cluster is stable. Going to try latest version now

[cwperks]

It was introduced in 2.31.32, can we try downgrading to that version?

With this version , cluster is stable. Going to try latest version now

Thank you for confirming :)

[RamHaridas]

Is there a plan to deprecate this parameter in any near future versions?

[cwperks]

Is there a plan to deprecate this parameter in any near future versions?

@RamHaridas is there an issue with this setting? Its supported so that some s3-compatible repositories can be used with this plugin.

[RamHaridas]

quiet the opposite 🙂, we need this flag to be available for our s3-compatible storage. Thank you for adding this @cwperks

[cwperks]

ah, thanks for confirming it works for you! :).

There is no plan to deprecate. This would maintain support for as long as its in the aws sdk.