Fixed missing error propagation in IndexNameExpressionResolver #19769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nils Bandener <[email protected]>
Contributor
Author
|
No changelog entry, as this fixes an issue introduced by a change that was not released yet. |
Contributor
|
❌ Gradle check result for d538aa4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cwperks
approved these changes
Oct 26, 2025
sandeshkr419
approved these changes
Oct 26, 2025
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19769 +/- ##
============================================
- Coverage 73.09% 73.08% -0.02%
+ Complexity 70954 70901 -53
============================================
Files 5737 5737
Lines 324760 324766 +6
Branches 46980 46981 +1
============================================
- Hits 237386 237354 -32
- Misses 68220 68279 +59
+ Partials 19154 19133 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anandpatel9998
pushed a commit
to anandpatel9998/OpenSearch
that referenced
this pull request
Nov 3, 2025
…earch-project#19769) Signed-off-by: Nils Bandener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a very specific issue in
IndexNameExpressionResolverthat was introduced in #18523. For requests with allow_no_indices = true, and an empty result set of matching expresssions, errors that were encountered before inWildcardExpressionResolverwere not propagated.This can happen only in very specific cases; the requirement that the result set is empty makes it necessary that the errors in
WildcardExpressionResolverare triggered by negated expressions; otherwise, the result set of matching expressions would not be empty.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.