[GRPC] Specify SourceContentType in search hits#19751
Draft
karenyrx wants to merge 2 commits intoopensearch-project:mainfrom
Draft
[GRPC] Specify SourceContentType in search hits#19751karenyrx wants to merge 2 commits intoopensearch-project:mainfrom
karenyrx wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Karen X <karenxyr@gmail.com>
Contributor
|
❌ Gradle check result for ef4faa9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for f2a6b8d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of different XContent formats for ingestion in the Bulk API (#19744), if mixed document formats are used, the search hits should be able to tell the user which xcontent format the document is stored in.
This PR is dependent on a protobuf version bump with this PR included opensearch-project/opensearch-protobufs#263 .
This PR is more of a quality of life change, rather than a hard blocker, so leaving this in draft mode until the PR to upgrade the protobuf version in core (and fix all compilation errors) is made.
Related Issues
Part of #19311
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.