Fix broken Gradle Spock's integration (skips Groovy tests)

[reta]

Description

Fix broken Gradle Spock's integration (skips Groovy tests). We didn't run these test suites for quite some time sadly due to Spock 2.0 changes with Junit 4 support.

Related Issues

Reported by @mishail over Slack

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 4a12e59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d987001: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 282a567: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 9827f6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for b3d25cc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 91fb31b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 9a45878: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for dd58c9a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for bc8913d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 46802b5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 268a871: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 806231c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 7f74b0b: SUCCESS

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.18%. Comparing base (147d6df) to head (846933a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19742      +/-   ##
============================================
+ Coverage     73.09%   73.18%   +0.09%     
  Complexity    70954    70954              
============================================
  Files          5737     5737              
  Lines        324760   324760              
  Branches      46980    46980              
============================================
+ Hits         237386   237684     +298     
+ Misses        68220    67887     -333     
- Partials      19154    19189      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[reta]

@andrross @cwperks would appreciate if you guys could take a look, thank you

[cwperks]

Thank you @reta! Sounds like we should find a way to get notified when tests stop running. In some instances the tests may be muted or deleted (expected) and that's ok, but in other instances when they stop running then we need to determine the reason why.

[reta]

Thank you @reta! Sounds like we should find a way to get notified when tests stop running

Thanks @cwperks , the only reliable way I know about is to track number of tests overtime - usually the progression is always increasing so it is somewhat easy to spot such issues when number of running tests goes down. To provide the concrete example, we should have around 38,786 tests at the moment:

This number should not be trending down upon major Gradle / frameworks updates.

[github-actions]

✅ Gradle check result for 846933a: SUCCESS