-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bump bwc on main with 3.3.2 bwcVersions #19734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
New min artifacts is building now. |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us merge this in asap as it is causing gradle check to fail on main with below error:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 3.3.1 didn't generate expected file /Users/akjain/ws/OpenSearch/distribution/bwc/bugfix/build/bwc/checkout-3.3/distribution/archives/linux-tar/build/distributions/opensearch-min-3.3.1-SNAPSHOT-linux-x64.tar.gz
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Seems like a flaky test: |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
|
The build is passing for me locally with this change: and I can see that the file is present: but jenkins build is not passing for some reason |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Both snapshot jars and min tar is available already, let's see in the next gradle check run. |
|
❌ Gradle check result for 0dac7cf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@peterzhuamazon - Still seeing the error related to jars and min tar, not sure what's going on here: |
Signed-off-by: Peter Zhu <[email protected]>
0dac7cf to
b028e7a
Compare
@jainankitk I believe the bwc tests will attempt to align based on date with a commit on the bwc branch. This prevents non-rebased PRs from failing due to things like serialization changes on newer PRs that are merge ahead of them. In this case we were missing the commit on the 3.3 branch that bumped the version to 3.3.2. I've rebased this PR which should fix it. |
Thanks @andrross for the explanation. This makes sense and answers few questions I have been wondering about regarding this version bump process.
Are you saying the 3.3 branch HEAD for bwc tests on this PR was set to something before #19732. But, that should not be the case if this PR was created after that was merged in!? |
|
❌ Gradle check result for b028e7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Few more flaky test failures: |
|
❌ Gradle check result for b028e7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b028e7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b028e7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Hi folks, |
|
@gaiksaya We've resolved the issues on this PR, but we're getting a bit unlucky with flaky failures. However, all other PRs will fail with bwc failures until this one is merged. |
@jainankitk This PR was created at 12:01 PDT. #19732 was merged at 13:14 PDT. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19734 +/- ##
============================================
- Coverage 73.14% 73.09% -0.06%
- Complexity 70797 70879 +82
============================================
Files 5732 5735 +3
Lines 324258 324654 +396
Branches 46925 46962 +37
============================================
+ Hits 237186 237302 +116
- Misses 67897 68208 +311
+ Partials 19175 19144 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Pending 3.3.2 official snapshots/min being built before merging
Description
Bump bwc on main with 3.3.2 bwcVersions
Related Issues
opensearch-project/opensearch-build#5784
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.