Skip to content

Conversation

@anti-social
Copy link
Contributor

Description

Fixes incorrect rewriting of terms query with more than 2 consecutive whole numbers

Related Issues

Resolves #19566

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

❕ Gradle check result for 9cbcfa2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.13%. Comparing base (006a53f) to head (d207a86).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19587      +/-   ##
============================================
+ Coverage     73.05%   73.13%   +0.08%     
- Complexity    70627    70708      +81     
============================================
  Files          5723     5723              
  Lines        323489   323490       +1     
  Branches      46851    46851              
============================================
+ Hits         236311   236581     +270     
+ Misses        68174    67807     -367     
- Partials      19004    19102      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anti-social
Copy link
Contributor Author

I added an entry to a 3.3 section of a changelog. Hope it will be backported

@anti-social anti-social force-pushed the fix-terms-query-rewrite branch from 76ccf5b to d207a86 Compare October 9, 2025 14:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

❌ Gradle check result for d207a86: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anti-social for adding this fix. I did not have in depth understanding of this code path, but could understand the issue and verify the logic using unit test. LGTM!

@jainankitk
Copy link
Contributor

I added an entry to a 3.3 section of a changelog. Hope it will be backported

Regarding 3.3, we have already frozen the code, so cannot guarantee that. But will try my best to get this accommodated, since this is bug fix, not a new feature.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

✅ Gradle check result for d207a86: SUCCESS

@jainankitk jainankitk merged commit 8a1c55f into opensearch-project:main Oct 9, 2025
42 of 44 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2025
Signed-off-by: Alexander Koval <[email protected]>
(cherry picked from commit 8a1c55f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jainankitk jainankitk mentioned this pull request Oct 9, 2025
3 tasks
peterzhuamazon pushed a commit that referenced this pull request Oct 9, 2025
…rs (#19588)

* Fix rewriting terms query with consecutive whole numbers (#19587)

Signed-off-by: Alexander Koval <[email protected]>
(cherry picked from commit 8a1c55f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update changelog entry

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: Alexander Koval <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ankit Jain <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <[email protected]>
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 3.3 Backport to 3.3 branch bug Something isn't working Search Search query, autocomplete ...etc v3.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] must_not that wraps terms query

2 participants