-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix rewriting terms query with consecutive whole numbers #19587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rewriting terms query with consecutive whole numbers #19587
Conversation
|
❕ Gradle check result for 9cbcfa2: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19587 +/- ##
============================================
+ Coverage 73.05% 73.13% +0.08%
- Complexity 70627 70708 +81
============================================
Files 5723 5723
Lines 323489 323490 +1
Branches 46851 46851
============================================
+ Hits 236311 236581 +270
+ Misses 68174 67807 -367
- Partials 19004 19102 +98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I added an entry to a |
Fixes opensearch-project#19566 Signed-off-by: Alexander Koval <[email protected]>
Signed-off-by: Alexander Koval <[email protected]>
76ccf5b to
d207a86
Compare
|
❌ Gradle check result for d207a86: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
jainankitk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anti-social for adding this fix. I did not have in depth understanding of this code path, but could understand the issue and verify the logic using unit test. LGTM!
Regarding |
Signed-off-by: Alexander Koval <[email protected]> (cherry picked from commit 8a1c55f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rs (#19588) * Fix rewriting terms query with consecutive whole numbers (#19587) Signed-off-by: Alexander Koval <[email protected]> (cherry picked from commit 8a1c55f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update changelog entry Signed-off-by: Ankit Jain <[email protected]> --------- Signed-off-by: Alexander Koval <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ankit Jain <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankit Jain <[email protected]>
…project#19587) Signed-off-by: Alexander Koval <[email protected]>
…project#19587) Signed-off-by: Alexander Koval <[email protected]>
Description
Fixes incorrect rewriting of terms query with more than 2 consecutive whole numbers
Related Issues
Resolves #19566
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.