Fix flakiness in FieldDataLoadingIT.testIndicesFieldDataCacheSizeSetting()#19571
Merged
jainankitk merged 3 commits intoopensearch-project:mainfrom Oct 8, 2025
Merged
Conversation
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
added 2 commits
October 8, 2025 14:35
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19571 +/- ##
============================================
+ Coverage 73.04% 73.08% +0.04%
+ Complexity 70587 70583 -4
============================================
Files 5719 5719
Lines 323288 323288
Branches 46818 46818
============================================
+ Hits 236147 236279 +132
+ Misses 68154 67964 -190
- Partials 18987 19045 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
approved these changes
Oct 8, 2025
Contributor
jainankitk
left a comment
jainankitk
left a comment
There was a problem hiding this comment.
Thanks @peteralfonsi for addressing the flaky test promptly. LGTM!
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 11, 2025
…ing() (opensearch-project#19571) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
peteralfonsi
added a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…ing() (opensearch-project#19571) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes flakiness in FieldDataLoadingIT.testIndicesFieldDataCacheSizeSetting().
The issue here was that on index creation, OpenSearch temporarily creates and then closes a test/temp index with the same name as the real index, using IndicesService.withTempIndexService(). The close causes the field data cache to wipe keys for that index name. But, since FDC cleanup is asynchronous and the cleanup interval for this test was 1 second, occasionally the wipe could happen after we run the first query on the real index but after we check that the resulting memory size of the cache is >0. That wiped the actual keys so the memory size was incorrectly 0.
We fix this by, after index creation, ensuring the cache clear cycle has completed. This is done by adding a key and then clearing the cache and waiting until the stats return to 0. Afterwards the tests can continue without risk of any extra FDC wipes at unexpected times.
Related Issues
Resolves #19431
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.