[2.19] remove license files from ingestion-kinesis which does not exist in 2.19 #19556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st in 2.19 Signed-off-by: Craig Perkins <[email protected]>
owaiskazi19
approved these changes
Oct 7, 2025
jainankitk
approved these changes
Oct 7, 2025
Contributor
|
I am wondering how these license files are getting into 2.x branch. Is that a miss while backporting the change? |
Member
Author
|
@jainankitk yes it was a miss in the backport here: #19270 Interestingly, the gradle check did not catch this. Its caught by the min distribution build failing. |
Contributor
Thanks for providing the additional context. Although I have limited understanding of min distribution build, so might not make sense. But, I am wondering if this check can be part of PR workflow? |
sokdak
pushed a commit
to sokdak/OpenSearch
that referenced
this pull request
Oct 15, 2025
…st in 2.19 (opensearch-project#19556) Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #19544, this PR removes more unused files from a plugin that exists in 3.x, but not in 2.x.
Related Issues
Fixes the 2.19.4 min distribution build: https://build.ci.opensearch.org/job/distribution-build-opensearch/11434
Resolves #19282
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.