Add a function to SearchPipelineService to check if system generated factory enabled or not - #19545
Merged
Merged
Conversation
bzhangam
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
October 6, 2025 17:25
…factory enabled or not. Signed-off-by: Bo Zhang <bzhangam@amazon.com>
owaiskazi19
approved these changes
Oct 6, 2025
Contributor
|
❕ Gradle check result for 8f8dbf3: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19545 +/- ##
==========================================
Coverage 73.00% 73.00%
- Complexity 70483 70528 +45
==========================================
Files 5717 5719 +2
Lines 323021 323205 +184
Branches 46790 46812 +22
==========================================
+ Hits 235826 235963 +137
+ Misses 68207 68198 -9
- Partials 18988 19044 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
owaiskazi19
pushed a commit
that referenced
this pull request
Oct 6, 2025
…factory enabled or not. (#19545) (#19547) (cherry picked from commit e638233) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions
Bot
added
enhancement
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 11, 2025
…factory enabled or not. (opensearch-project#19545) Signed-off-by: Bo Zhang <bzhangam@amazon.com>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Oct 13, 2025
…factory enabled or not. (opensearch-project#19545) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Gagan Singh Saini <gagasa@amazon.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…factory enabled or not. (opensearch-project#19545) Signed-off-by: Bo Zhang <bzhangam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a function to SearchPipelineService to check if system generated factory enabled or not so that plugins can consume this function rather than build their own.
Related Issues
Closes #19427
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.