Setting number of sharedArenaMaxPermits to 1 #19503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankit Jain <[email protected]>
Member
|
@jainankitk lets add change log, its worth calling out the fix. |
saratvemulapalli
approved these changes
Oct 2, 2025
Contributor
|
❌ Gradle check result for 4c665f2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ankit Jain <[email protected]>
jainankitk
changed the title
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19503 +/- ##
============================================
+ Coverage 72.97% 72.99% +0.02%
- Complexity 70417 70422 +5
============================================
Files 5711 5711
Lines 322587 322587
Branches 46716 46716
============================================
+ Hits 235402 235481 +79
+ Misses 68180 68114 -66
+ Partials 19005 18992 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Signed-off-by: Ankit Jain <[email protected]> (cherry picked from commit 983c4d7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Oct 2, 2025
(cherry picked from commit 983c4d7) Signed-off-by: Ankit Jain <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Ankit Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using shared Arena pooling, Lucene groups index files together into a single shared Arena to reduce the number of times it has to perform the costly operation of closing an Arena. However, in specific cases, this pooling can become a problem. Setting sharedArenaMaxPermits to a lower value like 1 can solve issues related to "leaked" maps or performance degradation caused by shared Arena pooling.
A value of 1 for sharedArenaMaxPermits effectively disables the pooling of shared Arenas. It forces each MMapDirectory instance to use a confined Arena, which is not owned by a specific thread but is managed in a way that avoids the performance issues associated with closing shared Arenas
Related Issues
Mitigates #19482
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.