Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Oct 1, 2025

Description

Bump io.grpc deps from 1.68.2 to 1.75.0

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner October 1, 2025 19:32
Signed-off-by: Craig Perkins <[email protected]>
@finnegancarroll
Copy link
Contributor

Just adding a note that client application libraries will still be on the previous version 1.68.2. According to this doc there shouldn't be any compatibility issues with these clients and in fact gRPC should be wire compatible across major versions.

Gave it a quick test with a python script on grpc 1.68.2 with no issue:

import grpc
import asyncio

from opensearch.protobufs.schemas import search_pb2
from opensearch.protobufs.schemas import common_pb2
from opensearch.protobufs.services.search_service_pb2_grpc import SearchServiceStub

async def make_request():
    channel = grpc.aio.insecure_channel(
        target="localhost:9400",
    )
    mtch_all_query = common_pb2.QueryContainer(match_all=common_pb2.MatchAllQuery())
    search_request = search_pb2.SearchRequest(
        request_body=search_pb2.SearchRequestBody(query=mtch_all_query),
        index=["test-index"],
        size=2
    )
    stub = SearchServiceStub(channel)
    resp = await stub.Search(search_request)
    print(resp)

asyncio.run(make_request())

LGTM.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

✅ Gradle check result for 6fdf929: SUCCESS

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.95%. Comparing base (32b6873) to head (6fdf929).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19495      +/-   ##
============================================
- Coverage     72.99%   72.95%   -0.05%     
+ Complexity    70416    70356      -60     
============================================
  Files          5708     5708              
  Lines        322492   322502      +10     
  Branches      46704    46705       +1     
============================================
- Hits         235412   235268     -144     
- Misses        68161    68287     +126     
- Partials      18919    18947      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@finnegancarroll
Copy link
Contributor

Tried out the same request with published java libraries also with no issue. Test code:

public class OpenSearchGrpcClient {
    public static void main(String[] args) {
        ManagedChannel channel = ManagedChannelBuilder
            .forAddress("localhost", 9400)
            .usePlaintext()
            .build();
        try {
            QueryContainer.Builder query_cont = QueryContainer.newBuilder().setMatchAll(MatchAllQuery.newBuilder());
            SearchRequestBody.Builder body = SearchRequestBody.newBuilder().setQuery(query_cont);
            SearchRequest request = SearchRequest.newBuilder()
                .setRequestBody(body)
                .addAllIndex(List.of("test-index"))
                .setSize(2)
                .build();
            SearchServiceGrpc.SearchServiceBlockingStub client = SearchServiceGrpc.newBlockingStub(channel);
            SearchResponse response = client.search(request);
            System.out.println("Response received: " + response.toString());
        } finally {
            channel.shutdown();
        }
    }
}

build.gradle versions:

def versions = [
  grpc: '1.68.2',
  guava: '31.1-jre',
  spotbugs_annotations: '4.7.3',
  error_prone_annotations: '2.18.0',
  opensearchprotobufs: '0.19.0',
  protobuf: '3.25.5'
]

@cwperks cwperks merged commit 99f3189 into opensearch-project:main Oct 1, 2025
33 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-19495-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99f3189b55a1eff8988f4598ab088cff95af1d20
# Push it to GitHub
git push --set-upstream origin backport/backport-19495-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-19495-to-2.19.

dbwiddis pushed a commit to dbwiddis/OpenSearch that referenced this pull request Oct 11, 2025
* Bump io.grpc deps from 1.68.2 to 1.75.0

Signed-off-by: Craig Perkins <[email protected]>

* Add CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 99f3189)
andrross pushed a commit that referenced this pull request Oct 13, 2025
(cherry picked from commit 99f3189)

Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
sokdak pushed a commit to sokdak/OpenSearch that referenced this pull request Oct 15, 2025
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
* Bump io.grpc deps from 1.68.2 to 1.75.0

Signed-off-by: Craig Perkins <[email protected]>

* Add CHANGELOG entry

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants