Skip to content

Conversation

@karenyrx
Copy link
Contributor

Description

Stacked on top of #19447
Implement GRPC Match Phrase, MultiMatch queries

Related Issues

Resolves #19389

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc labels Sep 29, 2025
Signed-off-by: Karen X <[email protected]>
@github-actions
Copy link
Contributor

❕ Gradle check result for 6425c3f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 98.01325% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.93%. Comparing base (28689b7) to head (a1eb423).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...earch/query/MatchPhraseQueryBuilderProtoUtils.java 95.23% 1 Missing and 1 partial ⚠️
...search/query/MultiMatchQueryBuilderProtoUtils.java 98.94% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19449      +/-   ##
============================================
- Coverage     72.96%   72.93%   -0.03%     
- Complexity    69969    70032      +63     
============================================
  Files          5676     5680       +4     
  Lines        321265   321407     +142     
  Branches      46445    46476      +31     
============================================
+ Hits         234407   234416       +9     
- Misses        67901    68079     +178     
+ Partials      18957    18912      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karenyrx karenyrx force-pushed the 0.18.0_match_matchphrase_multimatch branch from 6425c3f to c00df89 Compare September 29, 2025 07:42
@github-actions
Copy link
Contributor

❌ Gradle check result for c00df89: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx karenyrx closed this Sep 29, 2025
@karenyrx karenyrx reopened this Sep 29, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for c00df89: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@karenyrx karenyrx marked this pull request as ready for review September 29, 2025 18:41
@karenyrx karenyrx requested a review from a team as a code owner September 29, 2025 18:41
@github-actions
Copy link
Contributor

❕ Gradle check result for a1eb423: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2 mch2 merged commit db5106b into opensearch-project:main Sep 29, 2025
36 checks passed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…ries (opensearch-project#19449)

* upgrade to protobufs 0.18.0

Signed-off-by: Karen X <[email protected]>

* add tests

Signed-off-by: Karen X <[email protected]>

* [GRPC][Full-text] Match Phrase, Multi-match queries

Signed-off-by: Karen X <[email protected]>

* package private

Signed-off-by: Karen X <[email protected]>

---------

Signed-off-by: Karen X <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement Full-text GRPC Queries: Match, Match Phrase, Multi-match

2 participants