Add commons-lang3, commons-codec to plugin-cli#19387
Add commons-lang3, commons-codec to plugin-cli#19387rishabh6788 merged 1 commit intoopensearch-project:mainfrom
Conversation
The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well. Signed-off-by: Andrew Ross <andrross@amazon.com>
c03202c to
7746bba
Compare
|
❌ Gradle check result for 7746bba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 7746bba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19387 +/- ##
============================================
- Coverage 72.81% 72.81% -0.01%
+ Complexity 69838 69756 -82
============================================
Files 5674 5674
Lines 320850 320883 +33
Branches 46383 46390 +7
============================================
+ Hits 233624 233635 +11
+ Misses 68361 68310 -51
- Partials 18865 18938 +73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well. Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 067a8ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
I see commons-lang3 and commons-codec as api dependencies to ensure they're available at runtime. We did not observe any Gradle check failures in this commit: 5b89711. Previously, I created this issue #5208 to propose adding tests for native plugins within the core repository. Currently, we perform thorough plugin validation only after the distribution is built as part of the release process. However, having some level of testing directly in the core repository would provide a stronger quality metric. Another instance where plugin installation failed but no failures were caught in the core repository checks. Related PR with the fix #18147. |
) The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well. Signed-off-by: Andrew Ross <andrross@amazon.com>
The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well. (cherry picked from commit 067a8ae) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (opensearch-project#19394) The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well. (cherry picked from commit 067a8ae) Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.