Skip to content

Add commons-lang3, commons-codec to plugin-cli#19387

Merged
rishabh6788 merged 1 commit intoopensearch-project:mainfrom
andrross:add-commons-lang3-plugin-cli
Sep 24, 2025
Merged

Add commons-lang3, commons-codec to plugin-cli#19387
rishabh6788 merged 1 commit intoopensearch-project:mainfrom
andrross:add-commons-lang3-plugin-cli

Conversation

@andrross
Copy link
Member

@andrross andrross commented Sep 23, 2025

The updated version of commons compress in 5b89711 now requires that commons-lang3 to be available at runtime for the plugin CLI. commons-codec is also a non-optional dependency of commons-compress, so that is added here as well.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross requested a review from a team as a code owner September 23, 2025 22:30
The updated version of commons compress in 5b89711 now requires that
commons-lang3 to be available at runtime for the plugin CLI.
commons-codec is also a non-optional dependency of commons-compress, so
that is added here as well.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@andrross andrross force-pushed the add-commons-lang3-plugin-cli branch from c03202c to 7746bba Compare September 23, 2025 22:48
@andrross andrross changed the title Add commons-lang3 as a dependency of plugin-cli Add commons-lang3, commons-codec to plugin-cli Sep 23, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 7746bba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 7746bba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 7746bba: SUCCESS

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (a132bb5) to head (7746bba).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19387      +/-   ##
============================================
- Coverage     72.81%   72.81%   -0.01%     
+ Complexity    69838    69756      -82     
============================================
  Files          5674     5674              
  Lines        320850   320883      +33     
  Branches      46383    46390       +7     
============================================
+ Hits         233624   233635      +11     
+ Misses        68361    68310      -51     
- Partials      18865    18938      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rishabh6788 rishabh6788 merged commit 067a8ae into opensearch-project:main Sep 24, 2025
42 of 48 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2025
The updated version of commons compress in 5b89711 now requires that
commons-lang3 to be available at runtime for the plugin CLI.
commons-codec is also a non-optional dependency of commons-compress, so
that is added here as well.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 067a8ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@prudhvigodithi
Copy link
Member

I see commons-lang3 and commons-codec as api dependencies to ensure they're available at runtime.

We did not observe any Gradle check failures in this commit: 5b89711. Previously, I created this issue #5208 to propose adding tests for native plugins within the core repository. Currently, we perform thorough plugin validation only after the distribution is built as part of the release process. However, having some level of testing directly in the core repository would provide a stronger quality metric.

Another instance where plugin installation failed but no failures were caught in the core repository checks. Related PR with the fix #18147.

@gaiksaya @getsaurabh02

@andrross andrross deleted the add-commons-lang3-plugin-cli branch September 24, 2025 15:02
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
)

The updated version of commons compress in 5b89711 now requires that
commons-lang3 to be available at runtime for the plugin CLI.
commons-codec is also a non-optional dependency of commons-compress, so
that is added here as well.

Signed-off-by: Andrew Ross <andrross@amazon.com>
cwperks pushed a commit that referenced this pull request Sep 30, 2025
The updated version of commons compress in 5b89711 now requires that
commons-lang3 to be available at runtime for the plugin CLI.
commons-codec is also a non-optional dependency of commons-compress, so
that is added here as well.


(cherry picked from commit 067a8ae)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sokdak pushed a commit to sokdak/OpenSearch that referenced this pull request Oct 15, 2025
) (opensearch-project#19394)

The updated version of commons compress in 5b89711 now requires that
commons-lang3 to be available at runtime for the plugin CLI.
commons-codec is also a non-optional dependency of commons-compress, so
that is added here as well.


(cherry picked from commit 067a8ae)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants